public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: haavard.skinnemoen@atmel.com (Haavard Skinnemoen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3 v2] at91/atmel-mci: inclusion of sd/mmc driver in at91sam9g45 chip and board
Date: Sat, 7 Nov 2009 12:20:02 +0100	[thread overview]
Message-ID: <20091107122002.1ecf6483@hskinnemoen-d830> (raw)
In-Reply-To: <1257216943.4358.66.camel@ben-desktop>

Ben Nizette <bn@niasdigital.com> wrote:
> On Tue, 2009-11-03 at 15:30 +1300, Ryan Mallon wrote:
> > >   
> > IIRC, we can't mark static inline functions as weak, and we don't want
> > to turn gpio_is_valid into an actual function call. We could do some
> > preprocessor magic, but that gets a bit messy.  
> 
> Messy but generally accepted.

IIRC the most generally accepted way is to do

static inline bool gpio_is_valid(int pin)
{
	/* whatever */
}
#define gpio_is_valid gpio_is_valid

in the platform code and

#ifndef gpio_is_valid
/* provide definition of gpio_is_valid */
#endif

in the generic code. This way, there's only one symbol to grep for.

Haavard

  reply	other threads:[~2009-11-07 11:20 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090930155557.7dae503b@hskinnemoen-d830>
2009-10-23 16:34 ` [PATCH 0/2 v2]mmc: atmel-mci: introduce MCI2 support on at91 Nicolas Ferre
2009-10-23 16:34 ` [PATCH 1/3 v2] atmel-mci: change use of dma slave interface Nicolas Ferre
2009-10-23 16:34 ` [PATCH 2/3 v2] mmc: atmel-mci: New MCI2 module support in atmel-mci driver Nicolas Ferre
2009-11-02 17:18   ` Nicolas Ferre
2009-11-18 13:33     ` Nicolas Ferre
2009-10-23 16:34 ` [PATCH 3/3 v2] at91/atmel-mci: inclusion of sd/mmc driver in at91sam9g45 chip and board Nicolas Ferre
2009-10-26  8:15   ` Yegor Yefremov
2009-11-02 17:14     ` Nicolas Ferre
2009-10-27 19:43   ` Andrew Victor
2009-10-28  0:35     ` Haavard Skinnemoen
2009-10-28  0:53       ` Thiago A. Corrêa
2009-10-28  1:31         ` Haavard Skinnemoen
2009-10-28 19:53         ` Andrew Victor
2009-10-28 20:50           ` Ben Nizette
2009-11-02 17:11             ` Nicolas Ferre
2009-11-02 22:10               ` Ben Nizette
2009-11-02 22:14               ` Ben Nizette
2009-11-03  2:30               ` Ryan Mallon
2009-11-03  2:55                 ` Ben Nizette
2009-11-07 11:20                   ` Haavard Skinnemoen [this message]
2010-08-23 15:01                     ` [PATCH] pio: add arch specific gpio_is_valid() function Nicolas Ferre
2010-08-23 16:36                       ` David Brownell
2010-08-24  8:19                         ` Nicolas Ferre
2010-09-06 14:21                           ` [PATCH v2] AT91: pio: add " Nicolas Ferre
2010-09-07  1:51                             ` David Brownell
2010-09-03 16:41                       ` [PATCH] pio: add arch specific " Jean-Christophe PLAGNIOL-VILLARD
2010-09-07  2:23                         ` David Brownell
2010-09-07  2:44                           ` Ryan Mallon
2010-09-07  3:54                             ` Eric Miao
2010-09-07  4:07                               ` Ryan Mallon
2010-09-07  4:19                                 ` Eric Miao
2010-09-07  4:26                                   ` Ryan Mallon
2010-09-07 18:10                                     ` David Brownell
2010-09-07 19:13                                       ` avictor.za at gmail.com
2010-09-07 19:30                                         ` Ryan Mallon
2010-09-07 21:22                                           ` Alan Cox
2010-09-07 23:44                                             ` David Brownell
2010-09-08  0:11                                               ` Alan Cox
2010-09-07  6:33                             ` David Brownell
2010-09-07  8:41                               ` Ben Nizette
2010-09-07 17:32                                 ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091107122002.1ecf6483@hskinnemoen-d830 \
    --to=haavard.skinnemoen@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox