linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: omap: Use resource_size
Date: Mon, 9 Nov 2009 13:08:12 -0800	[thread overview]
Message-ID: <20091109210811.GE23952@atomide.com> (raw)
In-Reply-To: <20091109210558.GD23952@atomide.com>

* Tony Lindgren <tony@atomide.com> [091109 13:05]:
> * Tobias Klauser <tklauser@distanz.ch> [091109 09:44]:
> > Use the resource_size function instead of manually calculating the
> > resource size. This reduces the chance of introducing off-by-one errors
> > and actually fixes one in mailbox.c.
> > 
> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> 
> Acked-by: Tony Lindgren <tony@atomide.com>

Hmm, sorry though this was part of some larger series.. Added to
my omap-fixes queue.

Regards,

Tony
 
> > ---
> >  arch/arm/mach-omap2/gpmc.c    |    2 +-
> >  arch/arm/mach-omap2/mailbox.c |    2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> > index 004da69..67af370 100644
> > --- a/arch/arm/mach-omap2/gpmc.c
> > +++ b/arch/arm/mach-omap2/gpmc.c
> > @@ -366,7 +366,7 @@ int gpmc_cs_request(int cs, unsigned long size, unsigned long *base)
> >  	if (r < 0)
> >  		goto out;
> >  
> > -	gpmc_cs_enable_mem(cs, res->start, res->end - res->start + 1);
> > +	gpmc_cs_enable_mem(cs, res->start, resource_size(res));
> >  	*base = res->start;
> >  	gpmc_cs_set_reserved(cs, 1);
> >  out:
> > diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
> > index 46e1f2e..5ba3aa6 100644
> > --- a/arch/arm/mach-omap2/mailbox.c
> > +++ b/arch/arm/mach-omap2/mailbox.c
> > @@ -300,7 +300,7 @@ static int __devinit omap2_mbox_probe(struct platform_device *pdev)
> >  		dev_err(&pdev->dev, "invalid mem resource\n");
> >  		return -ENODEV;
> >  	}
> > -	mbox_base = ioremap(res->start, res->end - res->start);
> > +	mbox_base = ioremap(res->start, resource_size(res));
> >  	if (!mbox_base)
> >  		return -ENOMEM;
> >  
> > -- 
> > 1.6.3.3
> > 

      reply	other threads:[~2009-11-09 21:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09 17:44 [PATCH] arm: omap: Use resource_size Tobias Klauser
2009-11-09 21:05 ` Tony Lindgren
2009-11-09 21:08   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091109210811.GE23952@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).