From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [REGRESSION] 2eca40a8 breaks StrongARM compilation
Date: Wed, 11 Nov 2009 19:32:57 +0000 [thread overview]
Message-ID: <20091111193257.GA14775@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20091111192315.GA29757@rainbow>
On Wed, Nov 11, 2009 at 10:23:15PM +0300, Dmitry Artamonow wrote:
> Commit 2eca40a8 which went into 2.6.32-rc6 breaks compilation
> for ipaq h3600 and probably other SA1100 machines when CONFIG_CPU_FREQ
> is unset:
I'm aware, I have a very large patch which fixes SA1100, but there's
other ARM machine classes which are similarly broken.
We've been around this loop before, where a change like this was
introduced and reverted. The kernel community seems set to constantly
repeat the same old mistakes time and time again.
> +#ifdef CONFIG_CPU_FREQ
> pcd = get_pcd(var->pixclock, cpufreq_get(0));
> +#else
> + pcd = get_pcd(var->pixclock, 206400);
> +#endif
This is just not acceptable, and could lead to LCD panel damage due
to wrong timings - not all platforms boot at 206.4MHz. Given that
it's far better that the kernel be obviously broken than silently
wrong while causing hardware damage.
prev parent reply other threads:[~2009-11-11 19:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 19:23 [REGRESSION] 2eca40a8 breaks StrongARM compilation Dmitry Artamonow
2009-11-11 19:32 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091111193257.GA14775@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox