linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dk-arm-linux@gmx.de (Dieter Kiermaier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: enable PCI bridges after assigning resources (was orion/kirkwood pcie issue still open with 2.6.32-rc6 (marvell stock 2.6.22.18 works!))
Date: Thu, 12 Nov 2009 08:23:44 +0100	[thread overview]
Message-ID: <200911120823.46427.dk-arm-linux@gmx.de> (raw)
In-Reply-To: <1257989709.3918.8.camel@kero>

Hi Maxime, hi Lennert,

> 
> On Wed, 2009-11-11 at 18:19 +0100, Lennert Buytenhek wrote:
> 
> Hi Lennert & Dieter,
> 
> > It's the "Mem" one (surprise! :)).  The minus in "Mem-" indicates that
> > the bit is disabled in the Control register.
> 
> I sent this patch twice on arm mailing list but it went unnoticed. I
> think you're hitting the exact same problem.
> 
> 
> 
> When kernel is doing PCI resource assignment on ARM, nothing ever
> enables PCI bridges, preventing any device behind them from working. The
> following patch fixes this.
> 

You hit it :)
With your patch my FPGA works behind the bridge together with the marvell git u-boot.

@Lennert: now your debug printk's are shown during boot up!

To see things clear:
Is it possible that the marvell stock u-boot enables all devices before it starts the kernel
and that's the reason why it worked if I booted the kernel from stock u-boot and it didn't
work with the git u-boot?

Here is my:
Acked-by: Dieter Kiermaier <dk-arm-linux@gmx.de>

Additionally I will cook up a patch which clears the bit for M-Bus error reporting against most recent kernel
during the course of the day.

Many thanks to all for helping,
Dieter


> 
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> 
> --- linux-2.6.29/arch/arm/kernel/bios32.c.old	2009-04-16 22:43:18.000000000 +0200
> +++ linux-2.6.29/arch/arm/kernel/bios32.c	2009-04-16 22:43:25.000000000 +0200
> @@ -580,6 +580,7 @@
>  			 * Assign resources.
>  			 */
>  			pci_bus_assign_resources(bus);
> +			pci_enable_bridges(bus);
>  		}
>  
>  		/*
> 
> 
> 
> 

  reply	other threads:[~2009-11-12  7:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09  8:33 orion/kirkwood pcie issue still open with rc6 Dieter Kiermaier
2009-11-09  8:49 ` Simon Kagstrom
2009-11-09  9:06   ` Dieter Kiermaier
2009-11-10 15:26     ` Ronen Shitrit
2009-11-11 14:29     ` orion/kirkwood pcie issue still open with 2.6.32-rc6 (marvell stock 2.6.22.18 works!) Dieter Kiermaier
2009-11-11 15:21       ` Lennert Buytenhek
2009-11-11 16:43         ` Dieter Kiermaier
2009-11-11 16:59           ` Lennert Buytenhek
2009-11-11 17:18             ` Dieter Kiermaier
2009-11-11 16:50         ` Dieter Kiermaier
2009-11-11 16:53           ` Lennert Buytenhek
2009-11-11 17:11             ` Dieter Kiermaier
2009-11-11 17:19               ` Lennert Buytenhek
2009-11-11 17:46                 ` Dieter Kiermaier
2009-11-12  1:35                 ` [PATCH] ARM: enable PCI bridges after assigning resources (was orion/kirkwood pcie issue still open with 2.6.32-rc6 (marvell stock 2.6.22.18 works!)) Maxime Bizon
2009-11-12  7:23                   ` Dieter Kiermaier [this message]
2009-11-12  7:31                     ` Simon Kagstrom
2009-11-12  7:42                       ` Dieter Kiermaier
2009-11-12 19:56                   ` Lennert Buytenhek
2009-11-13 14:35                     ` Maxime Bizon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911120823.46427.dk-arm-linux@gmx.de \
    --to=dk-arm-linux@gmx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).