From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Prefix revision number in /proc/cpuinfo
Date: Thu, 12 Nov 2009 15:37:07 +0100 [thread overview]
Message-ID: <20091112143707.GO14091@buzzloop.caiaq.de> (raw)
In-Reply-To: <20091112143020.GA21329@mail.gnudd.com>
On Thu, Nov 12, 2009 at 03:30:20PM +0100, Alessandro Rubini wrote:
> > The revision field in /proc/cpuinfo is reported as hex number, so it
> > should have a '0x' prefix to make that clear. Otherwise, parsers
> > will take it as decimal number unless it contains a letter.
>
> If the problem is real (I assume it is), why don't you fix all
> fields?
>
> > - seq_printf(m, "Revision\t: %04x\n", system_rev);
> > + seq_printf(m, "Revision\t: 0x%04x\n", system_rev);
> > seq_printf(m, "Serial\t\t: %08x%08x\n",
> > system_serial_high, system_serial_low);
>
> "Serial", above, is hex as well.
Yes, but the serial number is more likely to be taken as string, I
thought. Anyway, below is a new patch.
Daniel
next prev parent reply other threads:[~2009-11-12 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 13:58 [PATCH] ARM: Prefix revision number in /proc/cpuinfo Daniel Mack
2009-11-12 14:30 ` Alessandro Rubini
2009-11-12 14:37 ` Daniel Mack [this message]
2009-11-12 21:52 ` Russell King - ARM Linux
2009-11-12 22:03 ` Daniel Mack
2009-11-12 22:13 ` Russell King - ARM Linux
2009-11-12 23:17 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091112143707.GO14091@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).