linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [ARM] IMX: don't disable the uart clock if DEBUG_LL uses it
Date: Fri, 13 Nov 2009 08:52:10 +0100	[thread overview]
Message-ID: <20091113075210.GF30179@pengutronix.de> (raw)
In-Reply-To: <1258062989-14493-1-git-send-email-u.kleine-koenig@pengutronix.de>

On Thu, Nov 12, 2009 at 10:56:29PM +0100, Uwe Kleine-K?nig wrote:
> Before the clock was left enabled only for DEBUG_LL_CONSOLE which
> requires an additional patch to exist at all.  With this patch applied
> DEBUG_LL_CONSOLE depends on DEBUG_LL, so this doesn't break.
> 
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  arch/arm/mach-mx2/clock_imx21.c |    2 +-
>  arch/arm/mach-mx2/clock_imx27.c |    2 +-
>  arch/arm/mach-mx3/clock-imx35.c |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-mx2/clock_imx21.c b/arch/arm/mach-mx2/clock_imx21.c
> index eede798..91901b5 100644
> --- a/arch/arm/mach-mx2/clock_imx21.c
> +++ b/arch/arm/mach-mx2/clock_imx21.c
> @@ -1000,7 +1000,7 @@ int __init mx21_clocks_init(unsigned long lref, unsigned long href)
>  	clk_enable(&per_clk[0]);
>  	clk_enable(&gpio_clk);
>  
> -#ifdef CONFIG_DEBUG_LL_CONSOLE
> +#if defined(CONFIG_DEBUG_LL) && !defined(CONFIG_DEBUG_ICEDCC)

If Catalins/my early printk patch goes in, wouldn't it be better to do
a

#if defined(CONFIG_EARLY_PRINTK) && !defined(CONFIG_DEBUG_ICEDCC)

here?


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2009-11-13  7:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-12 21:56 [PATCH] [ARM] IMX: don't disable the uart clock if DEBUG_LL uses it Uwe Kleine-König
2009-11-13  7:52 ` Sascha Hauer [this message]
2009-11-13  9:40   ` Uwe Kleine-König
2009-11-26 10:18     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091113075210.GF30179@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).