linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: simon.kagstrom@netinsight.net (Simon Kagstrom)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial21285: fix disable_irq-from-interrupt-handler deadlock
Date: Fri, 13 Nov 2009 09:02:34 +0100	[thread overview]
Message-ID: <20091113090234.7d028820@marrow.netinsight.se> (raw)

The console hangs during bootup when disable_irq is called from the
transmit interrupt handler (it will wait forever for it's "own"
interrupt in synchronize_irq). Fix by using disable_irq_nosync()
instead.

Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
---
Russell: This patch is a bit of RFC since I'm not quite sure that it's the correct
solution. It unbreaks booting on our footbridge-based platform. Let me
know if I should look at other solutions!

 drivers/serial/21285.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/serial/21285.c b/drivers/serial/21285.c
index 1e3d193..8681f13 100644
--- a/drivers/serial/21285.c
+++ b/drivers/serial/21285.c
@@ -58,7 +58,7 @@ static const char serial21285_name[] = "Footbridge UART";
 static void serial21285_stop_tx(struct uart_port *port)
 {
 	if (tx_enabled(port)) {
-		disable_irq(IRQ_CONTX);
+		disable_irq_nosync(IRQ_CONTX);
 		tx_enabled(port) = 0;
 	}
 }
@@ -74,7 +74,7 @@ static void serial21285_start_tx(struct uart_port *port)
 static void serial21285_stop_rx(struct uart_port *port)
 {
 	if (rx_enabled(port)) {
-		disable_irq(IRQ_CONRX);
+		disable_irq_nosync(IRQ_CONRX);
 		rx_enabled(port) = 0;
 	}
 }
-- 
1.6.0.4

             reply	other threads:[~2009-11-13  8:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13  8:02 Simon Kagstrom [this message]
2009-11-13  9:59 ` [PATCH] serial21285: fix disable_irq-from-interrupt-handler deadlock Russell King - ARM Linux
2009-11-13 10:08   ` Simon Kagstrom
2009-12-17  7:51   ` Simon Kagstrom
2010-01-10 12:26     ` Russell King - ARM Linux
2009-11-13 10:57 ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091113090234.7d028820@marrow.netinsight.se \
    --to=simon.kagstrom@netinsight.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).