From mboxrd@z Thu Jan  1 00:00:00 1970
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
Date: Fri, 13 Nov 2009 21:06:08 -0800
Subject: [PATCH 08/10] led: enable led in 88pm860x
In-Reply-To: <771cded00911130103m35c45c08ydf07cc8555438d69@mail.gmail.com>
References: <771cded00911130103m35c45c08ydf07cc8555438d69@mail.gmail.com>
Message-ID: <20091114050608.GD4463@core.coreip.homeip.net>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Fri, Nov 13, 2009 at 04:03:35AM -0500, Haojian Zhuang wrote:
> +
> +static void pm860x_led_set(struct led_classdev *cdev,
> +			   enum led_brightness value)
> +{
> +	struct pm860x_led *data = container_of(cdev, struct pm860x_led, cdev);
> +	struct pm860x_chip *chip = data->chip;
> +	unsigned char brightness;
> +	int offset;
> +	int ret = -EINVAL;
> +
> +	if (data->port < 0)
> +		return;

Same here - if port is negative why even bother with creating led
device?

-- 
Dmitry