linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 17/25] imx/eukrea_cpuimx27: use new nand device registration
Date: Mon, 16 Nov 2009 22:32:37 +0000	[thread overview]
Message-ID: <20091116223237.GG3568@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1258403708-10287-17-git-send-email-u.kleine-koenig@pengutronix.de>

On Mon, Nov 16, 2009 at 09:35:00PM +0100, Uwe Kleine-K?nig wrote:
>  static void __init eukrea_cpuimx27_init(void)
>  {
> +	struct mxc_nand_platform_data mxc_nand_pdata = {
> +		.width = 1,
> +		.hw_ecc = 1,
> +	};
> +

Have you checked what code the compiler spits out for this?

What the compiler will do is create a copy of the structure data in the
read-only data section.  It will allocate space on the stack, and memcpy
from that read-only version to the stack version.  It will then use the
stacked version for mxc_nand_data.

This saves nothing - the data remains in-core.

What you want to do is to keep the original definition, and mark it with
__initdata so that it gets discarded.

  parent reply	other threads:[~2009-11-16 22:32 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-16 20:34 [PATCH 00/25] imx cleanups Uwe Kleine-König
2009-11-16 20:34 ` [PATCH 01/25] imx: reorder mx2x.h Uwe Kleine-König
2009-11-16 20:34   ` [PATCH 02/25] imx: reorder mx21.h Uwe Kleine-König
2009-11-16 20:34     ` [PATCH 03/25] imx: reorder mx27.h Uwe Kleine-König
2009-11-16 20:34       ` [PATCH 04/25] imx: reorder mx3x.h Uwe Kleine-König
2009-11-16 20:34         ` [PATCH 05/25] imx: add namespace prefixes for symbols in mx2x.h Uwe Kleine-König
2009-11-16 20:34           ` [PATCH 06/25] imx: add namespace prefixes for symbols in mx21.h Uwe Kleine-König
2009-11-16 20:34             ` [PATCH 07/25] imx: add namespace prefixes for symbols in mx27.h Uwe Kleine-König
2009-11-16 20:34               ` [PATCH 08/25] imx: add namespace prefixes for symbols in mx3x.h Uwe Kleine-König
2009-11-16 20:34                 ` [PATCH 09/25] imx: add namespace prefixes for symbols in mx31.h Uwe Kleine-König
2009-11-16 20:34                   ` [PATCH 10/25] imx: add namespace prefixes for symbols in mx35.h Uwe Kleine-König
2009-11-16 20:34                     ` [PATCH 11/25] imx: reformat mx25.h to match the other platform includes Uwe Kleine-König
2009-11-16 20:34                       ` [PATCH 12/25] imx: copy constants from mx2x.h to mx21.h using the appropriate namespace Uwe Kleine-König
2009-11-16 20:34                         ` [PATCH 13/25] imx: copy constants from mx2x.h to mx27.h " Uwe Kleine-König
2009-11-16 20:34                           ` [PATCH 14/25] imx: copy constants from mx3x.h to mx31.h " Uwe Kleine-König
2009-11-16 20:34                             ` [PATCH 15/25] imx: copy constants from mx3x.h to mx35.h " Uwe Kleine-König
2009-11-16 20:34                               ` [PATCH 16/25] imx: generalize nand device registration Uwe Kleine-König
2009-11-16 20:35                                 ` [PATCH 17/25] imx/eukrea_cpuimx27: use new " Uwe Kleine-König
2009-11-16 20:35                                   ` [PATCH 18/25] imx/mx21ads: " Uwe Kleine-König
2009-11-16 20:35                                     ` [PATCH 19/25] imx/mx27ads: " Uwe Kleine-König
2009-11-16 20:35                                       ` [PATCH 20/25] imx/pca100: " Uwe Kleine-König
2009-11-16 20:35                                         ` [PATCH 21/25] imx/pcm038: " Uwe Kleine-König
2009-11-16 20:35                                           ` [PATCH 22/25] imx/armadillo5x0: " Uwe Kleine-König
2009-11-16 20:35                                             ` [PATCH 23/25] imx/mx31lite: " Uwe Kleine-König
2009-11-16 20:35                                               ` [PATCH 24/25] imx/pcm037: " Uwe Kleine-König
2009-11-16 20:35                                                 ` [PATCH 25/25] imx/mx25pdk: remove unused include Uwe Kleine-König
2009-11-16 22:32                                   ` Russell King - ARM Linux [this message]
2009-11-17  9:56                                     ` [PATCH 17/25] imx/eukrea_cpuimx27: use new nand device registration Uwe Kleine-König
2009-11-17 14:09                                       ` [PATCH] " Uwe Kleine-König
2009-11-17  9:54                                 ` [PATCH 16/25] imx: generalize " Uwe Kleine-König
2009-11-17 13:49                                 ` Uwe Kleine-König
2009-11-18  9:46 ` [PATCH 00/25] imx cleanups Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091116223237.GG3568@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).