From mboxrd@z Thu Jan  1 00:00:00 1970
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
Date: Tue, 17 Nov 2009 21:16:47 -0800
Subject: [PATCH 09/10] input: enable touch on 88pm860x
In-Reply-To: <771cded00911162227i24cd5a4cv9899e220b1c37c6e@mail.gmail.com>
References: <771cded00911130104s3bc6ff97ma3a7f7ad76ae9198@mail.gmail.com>
	<20091114025425.GA3587@core.coreip.homeip.net>
	<771cded00911162227i24cd5a4cv9899e220b1c37c6e@mail.gmail.com>
Message-ID: <20091118051646.GC31480@core.coreip.homeip.net>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Tue, Nov 17, 2009 at 01:27:42AM -0500, Haojian Zhuang wrote:
> 
> Up to now, I don't support module yet. When each component of this
> PMIC is ready, I'll enable module.
> 

I would do it rather sooner than later - then you'd notice that you are
not freeing IRQ in pm860x_touch_remove() when you'd try to reload your
module.

> +
> +static int __devexit pm860x_touch_remove(struct platform_device *pdev)
> +{
> +	struct pm860x_touch *touch = platform_get_drvdata(pdev);
> +
> +	input_unregister_device(touch->idev);
> +	return 0;
> +}
> +

-- 
Dmitry