linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ARM: MX3: add SPI devices for mx31lite
Date: Wed, 18 Nov 2009 16:42:56 +0100	[thread overview]
Message-ID: <20091118154256.GI14091@buzzloop.caiaq.de> (raw)
In-Reply-To: <20091118153708.GN30179@pengutronix.de>

On Wed, Nov 18, 2009 at 04:37:08PM +0100, Sascha Hauer wrote:
> On Wed, Nov 18, 2009 at 02:41:40PM +0100, Daniel Mack wrote:
> >  /*
> > + * SPI
> > + *
> > + * The MX13783 is hard-wired on the module, hence the corresponding
> > + * bus is registered here and not in the board code, in contrast to
> > + * the other SPI bus.
> > + */
> 
> 
> The mc13783 bus is registered in the -db file, and not here. I think you
> mixed something up here.

Hmm, no, that actually correct. The problem is that all devices on the
SPI bus have to be registered in one block via spi_register_board_info,
and as I don't know whether other boards will have more devices
connected, the registration is done in the board support file, not in
the module code.

The bus itself, however, is hardwired, so it makes no sense to add it
conditionally.

> s/MX13783/MC13783/

That's true :) Care to fix it on the fly or do you want me to resend?
There is btw another typo in the first mail of this series: In its
subject, it should have 'ARM' not 'ARN'.

The tradeoff of too small terminal fonts ;)

Daniel

  reply	other threads:[~2009-11-18 15:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-18 13:41 [PATCH 1/5] ARN: MX3: modularize 'mx31lite' code Daniel Mack
2009-11-18 13:41 ` [PATCH 2/5] ARM: MX3: add MMC/SDHC support to mx31lite-db.c Daniel Mack
2009-11-18 13:41   ` [PATCH 3/5] ARM: MX3: add SPI devices for mx31lite Daniel Mack
2009-11-18 13:41     ` [PATCH 4/5] ARM: MX3: add USB functions for mx31litekit Daniel Mack
2009-11-18 13:41       ` [PATCH 5/5] ARM: MX3: add support for GPIO LEDs on litekit db Daniel Mack
2009-11-18 15:37     ` [PATCH 3/5] ARM: MX3: add SPI devices for mx31lite Sascha Hauer
2009-11-18 15:42       ` Daniel Mack [this message]
2009-11-19  8:38         ` Sascha Hauer
2009-11-19  9:24           ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091118154256.GI14091@buzzloop.caiaq.de \
    --to=daniel@caiaq.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).