linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Add Samsung S5PC110 SoC support
Date: Wed, 18 Nov 2009 22:32:41 +0000	[thread overview]
Message-ID: <20091118223241.GD4808@trinity.fluff.org> (raw)
In-Reply-To: <1258551194-16018-1-git-send-email-m.szyprowski@samsung.com>

On Wed, Nov 18, 2009 at 02:32:55PM +0100, Marek Szyprowski wrote:
> Hello,
> 
> This preliminary patch series adds support for Samsung S5PC110 SoC.
> S5PC110 belongs to S5PC1XX family (CortexA8 ARM core), but differs in
> many places from the S5PC100 SoC: new memory map, different clock
> hierarchy, new gpio banks and much more powerful integrated peripherals.
> Such differences cannot be easily handled in the current Samsung
> machine&platform framework. To avoid duplication of code and adding yet
> another plat-* directory, we decided to introduce sub-platforms in
> the current s5pc1xx platform.
> 
> First 8 patches prepare s5pc1xx platform code for introduction of the
> new sub-platform approach. Then in the next 11 patches all core
> functions and drivers are subsequently added, so S5PC110 sub-platform
> gets similar level of support as S5PC100.
> 
> This patch series has been prepared against latest ARM Kernel tree from
> http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/linux-2.6-arm.git/
> 
> I know that Ben is working hard on new Samsung SoC platform framework,
> but stabilizing it and porting all the existing Samsung platforms would
> take time. This sub-platform solution is already prepared and until the
> new framework will be available and merged, we would like to use our
> approach.

running these through checkpatch first would have been a good idea:

fyi, these need fixing:

WARNING: externs should be avoided in .c files
#666: FILE: arch/arm/plat-s5pc1xx/s5pc110-clocks.c:92:
+extern struct clk clk_dout_hclkm;

WARNING: externs should be avoided in .c files
#667: FILE: arch/arm/plat-s5pc1xx/s5pc110-clocks.c:93:
+extern struct clk clk_dout_hclkd;

WARNING: externs should be avoided in .c files
#668: FILE: arch/arm/plat-s5pc1xx/s5pc110-clocks.c:94:
+extern struct clk clk_dout_hclkp;

WARNING: externs should be avoided in .c files
#669: FILE: arch/arm/plat-s5pc1xx/s5pc110-clocks.c:95:
+extern struct clk clk_dout_pclkd;

WARNING: externs should be avoided in .c files
#670: FILE: arch/arm/plat-s5pc1xx/s5pc110-clocks.c:96:
+extern struct clk clk_dout_pclkp;

#348: FILE: arch/arm/mach-s5pc110/include/plat/irqs.h:197:
+#define IRQ_EINT_BIT(x)		(x < IRQ_EINT16_31 ? x - IRQ_EINT0 : x - S3C_EINT(0))

could this be made an inline, or@least have x encased in brackets to
avoid any problems with macro expansion?

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

  parent reply	other threads:[~2009-11-18 22:32 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-18 13:32 [PATCH] Add Samsung S5PC110 SoC support Marek Szyprowski
2009-11-18 13:32 ` [PATCH 01/19] ARM: S5PC100: use 0x30008000 as memory base Marek Szyprowski
2009-11-18 13:32 ` [PATCH 02/19] ARM: S5PC1XX: create sub-platform for S5PC100 SoCs Marek Szyprowski
2009-11-18 13:32 ` [PATCH 03/19] ARM: S5PC1XX: prepare common cpu&clocks code for S5PC110 sub-platform Marek Szyprowski
2009-11-18 13:32 ` [PATCH 04/19] ARM: S5PC1XX: prepare common gpiolib " Marek Szyprowski
2009-11-18 13:33 ` [PATCH 05/19] ARM: S5PC1XX: move common s5pc1xx mach/* includes to plat-s5pc1xx/include/mach Marek Szyprowski
2009-11-18 13:33 ` [PATCH 06/19] ARM: S5PC1XX: cleanup of s5pc1xx common code Marek Szyprowski
2009-11-18 13:33 ` [PATCH 07/19] ARM: S5PC1XX: move s5pc100 specific device helpers to mach-s5pc100 dir Marek Szyprowski
2009-11-18 13:33 ` [PATCH 08/19] ARM: S5PC1XX: move common s5pc1xx s3c-fb regs to platform directory Marek Szyprowski
2009-11-18 19:56   ` Ben Dooks
2009-11-18 13:33 ` [PATCH 09/19] drivers: serial: add support for Samsung S5PC110 SoC uart Marek Szyprowski
2009-11-18 14:14   ` jassi brar
2009-11-18 22:13     ` Ben Dooks
2009-11-19  2:44       ` jassi brar
2009-11-19 10:33         ` Mark Brown
2009-11-19 11:05           ` jassi brar
2009-11-19 11:08             ` Mark Brown
2009-11-19 11:26               ` jassi brar
2009-11-19 11:32                 ` Mark Brown
2009-11-19 11:38               ` Russell King - ARM Linux
2009-11-19 11:48                 ` Mark Brown
2009-11-19 12:00                   ` Russell King - ARM Linux
2009-11-19 12:07                   ` jassi brar
2009-11-19 12:09                   ` Marek Szyprowski
2009-11-19 12:13                     ` Mark Brown
2009-11-19 12:19                     ` jassi brar
2009-11-23 10:38                     ` Russell King - ARM Linux
2009-11-18 13:33 ` [PATCH 10/19] ARM: S5PC1XX: add S5PC110 memory map Marek Szyprowski
2009-11-18 20:00   ` Ben Dooks
2009-11-19  8:23     ` Kyungmin Park
2009-11-18 13:33 ` [PATCH 11/19] ARM: S5PC1XX: add S5PC110 cpu initialization code Marek Szyprowski
2009-11-18 13:33 ` [PATCH 12/19] ARM: S5PC1XX: add support for s5pc110 plls and clocks Marek Szyprowski
2009-11-18 22:15   ` Ben Dooks
2009-11-18 13:33 ` [PATCH 13/19] ARM: S5PC1XX: add support for s5pc110 irqs Marek Szyprowski
2009-11-18 13:33 ` [PATCH 14/19] ARM: S5PC1XX: add support for s5pc110 gpio Marek Szyprowski
2009-11-18 22:05   ` Ben Dooks
2009-11-19 14:40     ` Marek Szyprowski
2009-11-18 13:33 ` [PATCH 15/19] ARM: S5PC1XX: add i2c platform helpers on s5pc110 sub-platform Marek Szyprowski
2009-11-18 13:33 ` [PATCH 16/19] ARM: S5PC1XX: enable S5PC110 sub-platform Marek Szyprowski
2009-11-18 13:33 ` [PATCH 17/19] ARM: S5PC1XX: add sdhci platform helpers for s5pc110 sub-platform Marek Szyprowski
2009-11-18 13:33 ` [PATCH 18/19] ARM: S5PC1XX: add framebuffer " Marek Szyprowski
2009-11-18 13:33 ` [PATCH 19/19] ARM: S5PC1XX: add support for SMDKC110 board Marek Szyprowski
2009-11-18 22:32 ` Ben Dooks [this message]
2009-11-20 13:42 ` [PATCH v2] Add Samsung S5PC110 SoC support Marek Szyprowski
2009-11-20 13:42 ` [PATCH 01/20] ARM: S5PC100: use 0x30008000 as memory base Marek Szyprowski
2009-11-20 14:42   ` jassi brar
2009-12-04  7:46     ` Marek Szyprowski
2009-11-20 13:42 ` [PATCH 02/20] ARM: S5PC1XX: create sub-platform for S5PC100 SoCs Marek Szyprowski
2009-11-20 13:42 ` [PATCH 03/20] ARM: S5PC1XX: prepare common cpu&clocks code for S5PC110 sub-platform Marek Szyprowski
2009-11-20 13:42 ` [PATCH 04/20] ARM: S5PC1XX: prepare common gpiolib " Marek Szyprowski
2009-11-20 13:42 ` [PATCH 05/20] ARM: S5PC1XX: move common s5pc1xx mach/* includes to plat-s5pc1xx/include/mach Marek Szyprowski
2009-11-20 13:42 ` [PATCH 06/20] ARM: S5PC1XX: cleanup of s5pc1xx common code Marek Szyprowski
2009-11-20 13:42 ` [PATCH 07/20] ARM: S5PC1XX: move s5pc100 specific device helpers to mach-s5pc100 dir Marek Szyprowski
2009-11-20 13:42 ` [PATCH 08/20] ARM: S5PC1XX: move common s5pc1xx s3c-fb regs to platform directory Marek Szyprowski
2009-11-20 13:42 ` [PATCH 09/20] drivers: serial: add support for Samsung S5PC110 SoC uart Marek Szyprowski
2009-11-20 13:42 ` [PATCH 10/20] ARM: S5PC1XX: add S5PC110 memory map Marek Szyprowski
2009-11-20 13:42 ` [PATCH 11/20] ARM: S5PC1XX: add S5PC110 cpu initialization code Marek Szyprowski
2009-11-20 13:42 ` [PATCH 12/20] ARM: S5PC1XX: add support for s5pc110 plls and clocks Marek Szyprowski
2009-11-20 13:42 ` [PATCH 13/20] ARM: S5PC1XX: add support for s5pc110 irqs Marek Szyprowski
2009-11-20 13:42 ` [PATCH 14/20] ARM: S5PC1XX: add support for s5pc110 gpio Marek Szyprowski
2009-11-20 13:42 ` [PATCH 15/20] ARM: S5PC1XX: add i2c platform helpers on s5pc110 sub-platform Marek Szyprowski
2009-11-20 13:42 ` [PATCH 16/20] ARM: S5PC1XX: enable S5PC110 sub-platform Marek Szyprowski
2009-11-20 13:42 ` [PATCH 17/20] ARM: S5PC1XX: add sdhci platform helpers for s5pc110 sub-platform Marek Szyprowski
2009-11-20 13:42 ` [PATCH 18/20] ARM: S5PC1XX: add framebuffer " Marek Szyprowski
2009-11-20 13:42 ` [PATCH 19/20] ARM: S5PC1XX: add support for SMDKC110 board Marek Szyprowski
2009-11-20 13:42 ` [PATCH 20/20] MAINTAINERS: add ARM/S5PC100 and ARM/S5PC110 architectures Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091118223241.GD4808@trinity.fluff.org \
    --to=ben-linux@fluff.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).