linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: i.MX audio support
Date: Thu, 19 Nov 2009 16:28:30 +0000	[thread overview]
Message-ID: <20091119162830.GA31336@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1258645706-9071-1-git-send-email-s.hauer@pengutronix.de>

On Thu, Nov 19, 2009 at 04:48:14PM +0100, Sascha Hauer wrote:

> There already is a driver for i.MX in the tree, this one is a nearly complete
> rewrite. I haven't touched the in Kernel driver with these patches. The in
> Kernel driver has several problems, it doesn't use ioremap, uses direct pointer
> derefs instead of proper access functions and the only board supported so far is
> itself not supported in mainline.

I've CCed in Javier who wrote the currently merged code.

I'll review these patches tomorrow or over the weekend, however this
jumps out at me as being something that we'd want to fix before merging
since having two drivers for the same bit of hardware always leads to
problems going forwards.  I don't mind how this is addressed, replacing
the existing driver or incrementally fixing it would both work for me
(the latter is obviously preferrable but equally well we don't want to
get bogged down).

The approach of using FIQ for i.MX3x until SDMA gets merged seems like a
reasonable one.  It's not ideal but it will work and it shouldn't create
any problems transitioning to SDMA when that is submitted.

BTW, might be nice to use --no-chain-reply-to for git send-email - it
makes long patch sets look a lot nicer in a threaded mail reader.  Not a
big deal, though.

  parent reply	other threads:[~2009-11-19 16:28 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-19 15:48 i.MX audio support Sascha Hauer
2009-11-19 15:48 ` [PATCH 01/12] mx3: Add SSI pins to iomux table Sascha Hauer
2009-11-19 15:48   ` [PATCH 02/12] mxc: iomux v3: remove resource handling Sascha Hauer
2009-11-19 15:48     ` [PATCH 03/12] add a mc13783 codec driver Sascha Hauer
2009-11-19 15:48       ` [PATCH 04/12] i.MX31 clock: rename SSI clocks to driver name Sascha Hauer
2009-11-19 15:48         ` [PATCH 05/12] mxc: mx1/mx2 DMA: add a possibility to create an endless DMA transfer Sascha Hauer
2009-11-19 15:48           ` [PATCH 06/12] imx-ssi sound driver Sascha Hauer
2009-11-19 15:48             ` [PATCH 07/12] add phycore sound support Sascha Hauer
2009-11-19 15:48               ` [PATCH 08/12] sound/soc/imx: Makefile/Kconfig changes for new driver Sascha Hauer
2009-11-19 15:48                 ` [PATCH 09/12] pcm038: add sound support Sascha Hauer
2009-11-19 15:48                   ` [PATCH 10/12] pcm043: " Sascha Hauer
2009-11-19 15:48                     ` [PATCH 11/12] pca100: " Sascha Hauer
2009-11-19 15:48                       ` [PATCH 12/12] pcm037: Add " Sascha Hauer
2009-11-19 19:03               ` [alsa-devel] [PATCH 07/12] add phycore " Mark Brown
2009-11-20 11:11             ` [alsa-devel] [PATCH 06/12] imx-ssi sound driver Mark Brown
2009-11-22  2:12             ` Timur Tabi
2009-11-23 12:00               ` Mark Brown
2009-11-23 12:13                 ` Sascha Hauer
2009-11-28 22:00                   ` Timur Tabi
2009-11-23 12:10               ` Sascha Hauer
2009-11-28 19:53                 ` Timur Tabi
2009-11-19 19:30       ` [alsa-devel] [PATCH 03/12] add a mc13783 codec driver Mark Brown
2009-11-25  7:46         ` Sascha Hauer
2009-11-25 10:39           ` Mark Brown
2009-11-25 11:08             ` Sascha Hauer
2009-11-25 11:10               ` Mark Brown
2009-11-25 11:30                 ` Sascha Hauer
2009-11-25 12:00                   ` Mark Brown
2009-11-19 16:28 ` Mark Brown [this message]
2009-11-19 17:53   ` i.MX audio support Sascha Hauer
2009-11-19 18:54     ` [alsa-devel] " Mark Brown
2009-11-20  7:51       ` javier Martin
2009-11-20  9:51         ` Sascha Hauer
2009-11-20 10:32           ` javier Martin
2009-11-20 11:10             ` Sascha Hauer
2009-11-19 16:32 ` Mark Brown
2009-11-19 17:47   ` [alsa-devel] " Sascha Hauer
2009-11-19 18:32     ` Mark Brown
2009-11-20 11:17 ` Mark Brown
2009-11-20 12:27   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091119162830.GA31336@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).