[PATCH 2/3] staging/dream: add missing include files

[PATCH 2/3] staging/dream: add missing include files

[Greg KH]

On Sun, Nov 01, 2009 at 11:27:17PM +0100, Pavel Machek wrote:
> Add missing files/includes neccessary for Dream compilation.
>     
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

This patch includes a file that is not in the drivers/staging/
directory, and it does this Kconfig mess:

> +config GENERIC_GPIO
> +	bool
> +	default y

Which breaks the i386 build.  Don't force on a general config option
like this, that's not nice at all :(

So I'll not apply this one, and the 3/3 patch.

thanks,

greg k-h

[PATCH 2/3] staging/dream: add missing include files

[Pavel Machek]

On Thu 2009-11-19 14:56:02, Greg KH wrote:
> On Sun, Nov 01, 2009 at 11:27:17PM +0100, Pavel Machek wrote:
> > Add missing files/includes neccessary for Dream compilation.
> >     
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> This patch includes a file that is not in the drivers/staging/
> directory, and it does this Kconfig mess:

Oops, sorry. That one escaped me. I'll submit fixed version.

> > +config GENERIC_GPIO
> > +	bool
> > +	default y
> 
> Which breaks the i386 build.  Don't force on a general config option
> like this, that's not nice at all :(

Ok, I should figure out how to limit it to arch-msm.

> So I'll not apply this one, and the 3/3 patch.

Where can I get the tree to diff against?
gregkh-08-staging-2.6.32-rc7-git4.patch just reverts everything.

I guess I can extract it from
://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/series ...

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[PATCH 2/3] staging/dream: add missing include files

[Russell King - ARM Linux]

On Fri, Nov 20, 2009 at 11:57:26AM +0100, Pavel Machek wrote:
> On Thu 2009-11-19 14:56:02, Greg KH wrote:
> > On Sun, Nov 01, 2009 at 11:27:17PM +0100, Pavel Machek wrote:
> > > +config GENERIC_GPIO
> > > +	bool
> > > +	default y
> > 
> > Which breaks the i386 build.  Don't force on a general config option
> > like this, that's not nice at all :(
> 
> Ok, I should figure out how to limit it to arch-msm.

You do it by 'select'ing the symbol in arch/arm/Kconfig.  See the many
other examples therein of how to do it.

[PATCH 2/3] staging/dream: add missing include files

[Greg KH]

On Fri, Nov 20, 2009 at 11:57:26AM +0100, Pavel Machek wrote:
> Where can I get the tree to diff against?
> gregkh-08-staging-2.6.32-rc7-git4.patch just reverts everything.
> 
> I guess I can extract it from
> ://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/series ...

Or grab the linux-next tree and branch from right before the "delete the
drivers/staging/dream/ directory" patch.

thanks,

greg k-h

[PATCH 2/3] staging/dream: add missing include files

[Pavel Machek]

On Fri 2009-11-20 07:30:54, Greg KH wrote:
> On Fri, Nov 20, 2009 at 11:57:26AM +0100, Pavel Machek wrote:
> > Where can I get the tree to diff against?
> > gregkh-08-staging-2.6.32-rc7-git4.patch just reverts everything.
> > 
> > I guess I can extract it from
> > ://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/series ...
> 
> Or grab the linux-next tree and branch from right before the "delete the
> drivers/staging/dream/ directory" patch.

What is the status here, BTW? staging/dream is still there in git pull
from today. Would it be possible to avoid pushing that huge revert to
Linus, after all? Fixes are available, and it would be nice to avoid
big churn.... Pretty please...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[PATCH 2/3] staging/dream: add missing include files

[Pavel Machek]

On Fri 2009-11-20 11:07:28, Russell King - ARM Linux wrote:
> On Fri, Nov 20, 2009 at 11:57:26AM +0100, Pavel Machek wrote:
> > On Thu 2009-11-19 14:56:02, Greg KH wrote:
> > > On Sun, Nov 01, 2009 at 11:27:17PM +0100, Pavel Machek wrote:
> > > > +config GENERIC_GPIO
> > > > +	bool
> > > > +	default y
> > > 
> > > Which breaks the i386 build.  Don't force on a general config option
> > > like this, that's not nice at all :(
> > 
> > Ok, I should figure out how to limit it to arch-msm.
> 
> You do it by 'select'ing the symbol in arch/arm/Kconfig.  See the many
> other examples therein of how to do it.

Thanks.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[PATCH 2/3] staging/dream: add missing include files

[Greg KH]

On Sun, Dec 06, 2009 at 10:52:57PM +0100, Pavel Machek wrote:
> On Fri 2009-11-20 07:30:54, Greg KH wrote:
> > On Fri, Nov 20, 2009 at 11:57:26AM +0100, Pavel Machek wrote:
> > > Where can I get the tree to diff against?
> > > gregkh-08-staging-2.6.32-rc7-git4.patch just reverts everything.
> > > 
> > > I guess I can extract it from
> > > ://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/series ...
> > 
> > Or grab the linux-next tree and branch from right before the "delete the
> > drivers/staging/dream/ directory" patch.
> 
> What is the status here, BTW? staging/dream is still there in git pull
> from today. Would it be possible to avoid pushing that huge revert to
> Linus, after all? Fixes are available, and it would be nice to avoid
> big churn.... Pretty please...

Sorry for the delay.

I've pushed out the staging patches for .33, and left in the Dream
files, as you are trying very hard to get this to work, and to delete
them now would just be rude of me.  I'll drop the patch from -next that
removes the files as well when I sync up with Linus later today.

I'll also work through the patches you have sent me so far that I
haven't applied, I think there are still a few.

Hope this helps,

greg k-h

[PATCH 2/3] staging/dream: add missing include files

[Pavel Machek]

On Sat 2009-12-12 11:02:05, Greg KH wrote:
> On Sun, Dec 06, 2009 at 10:52:57PM +0100, Pavel Machek wrote:
> > On Fri 2009-11-20 07:30:54, Greg KH wrote:
> > > On Fri, Nov 20, 2009 at 11:57:26AM +0100, Pavel Machek wrote:
> > > > Where can I get the tree to diff against?
> > > > gregkh-08-staging-2.6.32-rc7-git4.patch just reverts everything.
> > > > 
> > > > I guess I can extract it from
> > > > ://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/series ...
> > > 
> > > Or grab the linux-next tree and branch from right before the "delete the
> > > drivers/staging/dream/ directory" patch.
> > 
> > What is the status here, BTW? staging/dream is still there in git pull
> > from today. Would it be possible to avoid pushing that huge revert to
> > Linus, after all? Fixes are available, and it would be nice to avoid
> > big churn.... Pretty please...
> 
> Sorry for the delay.
> 
> I've pushed out the staging patches for .33, and left in the Dream
> files, as you are trying very hard to get this to work, and to delete
> them now would just be rude of me.  I'll drop the patch from -next that
> removes the files as well when I sync up with Linus later today.
> 
> I'll also work through the patches you have sent me so far that I
> haven't applied, I think there are still a few.
> 
> Hope this helps,

Yep, thanks!

(Things are getting better... slowly. Google now has android/dream
tree based on 2.6.32, and first bits of dream support are being merged...)
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html