linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/10] input: enable touch on 88pm860x
Date: Fri, 20 Nov 2009 00:44:57 -0800	[thread overview]
Message-ID: <20091120084457.GD3009@core.coreip.homeip.net> (raw)
In-Reply-To: <771cded00911191902s171a9fe4ucb21ea0c75bb12cb@mail.gmail.com>

Hi Haojian,

On Thu, Nov 19, 2009 at 10:02:23PM -0500, Haojian Zhuang wrote:
> +
> +static int __devexit pm860x_touch_remove(struct platform_device *pdev)
> +{
> +	struct pm860x_touch *touch = platform_get_drvdata(pdev);
> +

"pm860x_free_irq(chip, irq);" is still missing here.

> +	input_unregister_device(touch->idev);
> +	return 0;
> +}
> +
>  
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called pcap_ts.
> +
> +config TOUCHSCREEN_88PM860X
> +	tristate "Marvell 88PM860x touchscreen"
> +	depends on MFD_88PM860X
> +	help
> +	  Say Y here if you have a 88PM860x PMIC and want to enable
> +	  support for the built-in touchscreen.

"To compile this driver as a module..."

Thanks!

Other than that:

	Acked-by: Dmitry Torokhov <dtor@mail.ru>

-- 
Dmitry

  reply	other threads:[~2009-11-20  8:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13  9:04 [PATCH 09/10] input: enable touch on 88pm860x Haojian Zhuang
2009-11-13 13:09 ` Mark Brown
2009-11-14  2:54 ` Dmitry Torokhov
2009-11-17  6:27   ` Haojian Zhuang
2009-11-18  5:16     ` Dmitry Torokhov
2009-11-20  3:02       ` Haojian Zhuang
2009-11-20  8:44         ` Dmitry Torokhov [this message]
2009-11-20  9:13           ` Haojian Zhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091120084457.GD3009@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).