linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/12] imx-ssi sound driver
Date: Mon, 23 Nov 2009 13:10:55 +0100	[thread overview]
Message-ID: <20091123121055.GE30179@pengutronix.de> (raw)
In-Reply-To: <ed82fe3e0911211812i49342b0eg2afe861c866db90c@mail.gmail.com>

On Sat, Nov 21, 2009 at 08:12:34PM -0600, Timur Tabi wrote:
> On Thu, Nov 19, 2009 at 9:48 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > ?arch/arm/plat-mxc/Makefile ? ? ? ? ? | ? ?1 +
> > ?arch/arm/plat-mxc/include/mach/ssi.h | ? 17 +
> > ?arch/arm/plat-mxc/ssi-fiq.S ? ? ? ? ?| ?134 ++++
> > ?sound/soc/imx/devdma.c ? ? ? ? ? ? ? | ? 80 ++
> > ?sound/soc/imx/devdma.h ? ? ? ? ? ? ? | ? ?3 +
> > ?sound/soc/imx/imx-ssi.c ? ? ? ? ? ? ?| 1349 ++++++++++++++++++++++++++++++++++
> > ?sound/soc/imx/imx-ssi.h ? ? ? ? ? ? ?| ? 24 +
> 
> Why did you write a new SSI driver when there already is one in sound/soc/fsl?

Mainly because I wasn't aware of the fact that the fsl driver is the
same :(

I'm currently looking if and how the code can be merged. I don't know if
it's worth it though since the common code doesn't seem to be very big.

There will have to be some changes in the fsl-ssi driver. For example I
need the irq handler for my fiq handler which means that the fsl-ssi
driver is not allowed to request the irq for it's statistic. The other
thing is the hardware accesses as we do not have in_be*, out_be* and
setbits/clrbits. Of course all these things are doable and shouldn't be
a showstopper.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2009-11-23 12:10 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-19 15:48 i.MX audio support Sascha Hauer
2009-11-19 15:48 ` [PATCH 01/12] mx3: Add SSI pins to iomux table Sascha Hauer
2009-11-19 15:48   ` [PATCH 02/12] mxc: iomux v3: remove resource handling Sascha Hauer
2009-11-19 15:48     ` [PATCH 03/12] add a mc13783 codec driver Sascha Hauer
2009-11-19 15:48       ` [PATCH 04/12] i.MX31 clock: rename SSI clocks to driver name Sascha Hauer
2009-11-19 15:48         ` [PATCH 05/12] mxc: mx1/mx2 DMA: add a possibility to create an endless DMA transfer Sascha Hauer
2009-11-19 15:48           ` [PATCH 06/12] imx-ssi sound driver Sascha Hauer
2009-11-19 15:48             ` [PATCH 07/12] add phycore sound support Sascha Hauer
2009-11-19 15:48               ` [PATCH 08/12] sound/soc/imx: Makefile/Kconfig changes for new driver Sascha Hauer
2009-11-19 15:48                 ` [PATCH 09/12] pcm038: add sound support Sascha Hauer
2009-11-19 15:48                   ` [PATCH 10/12] pcm043: " Sascha Hauer
2009-11-19 15:48                     ` [PATCH 11/12] pca100: " Sascha Hauer
2009-11-19 15:48                       ` [PATCH 12/12] pcm037: Add " Sascha Hauer
2009-11-19 19:03               ` [alsa-devel] [PATCH 07/12] add phycore " Mark Brown
2009-11-20 11:11             ` [alsa-devel] [PATCH 06/12] imx-ssi sound driver Mark Brown
2009-11-22  2:12             ` Timur Tabi
2009-11-23 12:00               ` Mark Brown
2009-11-23 12:13                 ` Sascha Hauer
2009-11-28 22:00                   ` Timur Tabi
2009-11-23 12:10               ` Sascha Hauer [this message]
2009-11-28 19:53                 ` Timur Tabi
2009-11-19 19:30       ` [alsa-devel] [PATCH 03/12] add a mc13783 codec driver Mark Brown
2009-11-25  7:46         ` Sascha Hauer
2009-11-25 10:39           ` Mark Brown
2009-11-25 11:08             ` Sascha Hauer
2009-11-25 11:10               ` Mark Brown
2009-11-25 11:30                 ` Sascha Hauer
2009-11-25 12:00                   ` Mark Brown
2009-11-19 16:28 ` i.MX audio support Mark Brown
2009-11-19 17:53   ` Sascha Hauer
2009-11-19 18:54     ` [alsa-devel] " Mark Brown
2009-11-20  7:51       ` javier Martin
2009-11-20  9:51         ` Sascha Hauer
2009-11-20 10:32           ` javier Martin
2009-11-20 11:10             ` Sascha Hauer
2009-11-19 16:32 ` Mark Brown
2009-11-19 17:47   ` [alsa-devel] " Sascha Hauer
2009-11-19 18:32     ` Mark Brown
2009-11-20 11:17 ` Mark Brown
2009-11-20 12:27   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091123121055.GE30179@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).