From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/10] ARM: PNX4008: convert watchdog to use clk API enable/disable calls
Date: Mon, 23 Nov 2009 23:50:12 +0000 [thread overview]
Message-ID: <20091123235012.GK18142@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <083DF309106F364B939360100EC290F804F55464A2@eu1rdcrdc1wx030.exi.nxp.com>
On Tue, Nov 24, 2009 at 12:38:12AM +0100, Kevin Wells wrote:
> The wdt_enable() functions also assumes a wdt counter rate of 13MHz
> with the WDOG_COUNTER_RATE macro. I think this was ok for the original
> PNX part, but the LPC32XX platform's rate will vary based on the
> system clock rate of the device. The nominal rate is 13.325MHz.
>
> I've checked the previous 3 WDT patches and made the necessary changes
> to my clock driver and everything still works on the LPC32xx platforms,
> but can't check changes on the PNX4008 platform (have no hardware).
>
> I'll submit a patch to use clk_get_rate instead of the macro..
Great. As far as switching to clk_get_rate, the PNX4008 code is not
nice in that regard, but it will be made to return the desired 13MHz
value. ;)
Out of interest, the PNX4008 code hasn't been seriously touched since
December 2006 - does anyone care about it? I've not had any reply
from Vitaly, so I suspect he doesn't have anything to do with it
anymore.
If the answer is no, it might be a good idea to declare the code dead
and schedule it for removal in maybe six months time.
next prev parent reply other threads:[~2009-11-23 23:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 14:44 [PATCH 0/10] PNX clock API fixes Russell King - ARM Linux
2009-11-20 10:32 ` [PATCH 01/10] ARM: PNX4008: convert to clkdev Russell King - ARM Linux
2009-11-20 10:46 ` [PATCH 06/10] ARM: PNX4008: convert i2c clocks to match by device only Russell King - ARM Linux
2009-11-20 10:50 ` [PATCH 07/10] ARM: PNX4008: move i2c suspend/resume callbacks into driver Russell King - ARM Linux
2009-11-21 12:53 ` Russell King - ARM Linux
2009-11-23 18:22 ` Vitaly Wool
2009-11-21 17:27 ` Linus Walleij
2009-11-21 18:59 ` Russell King - ARM Linux
2009-11-23 17:30 ` Kevin Wells
2009-11-25 21:19 ` Kevin Wells
2009-12-14 23:06 ` Russell King - ARM Linux
2009-12-15 0:16 ` Kevin Wells
2009-11-20 11:12 ` [PATCH 08/10] ARM: PNX4008: move i2c clock start/stop " Russell King - ARM Linux
2009-11-20 11:25 ` [PATCH 02/10] ARM: PNX4008: simplify clk enable/disable paths Russell King - ARM Linux
2009-11-20 11:28 ` [PATCH 03/10] ARM: PNX4008: provide clock enable/disable methods and initialization Russell King - ARM Linux
2009-11-20 11:44 ` [PATCH 09/10] ARM: PNX4008: convert i2c-pnx to use clk API enable/disable calls Russell King - ARM Linux
2009-11-20 12:46 ` [PATCH 10/10] ARM: PNX4008: get i2c clock rate from clk API Russell King - ARM Linux
2009-11-20 13:04 ` [PATCH 05/10] ARM: PNX4008: convert watchdog to use clk API enable/disable calls Russell King - ARM Linux
2009-11-20 15:03 ` Wim Van Sebroeck
2009-11-23 23:38 ` Kevin Wells
2009-11-23 23:50 ` Russell King - ARM Linux [this message]
2009-11-20 13:07 ` [PATCH 04/10] ARM: PNX4008: convert watchdog clocks to match by device only Russell King - ARM Linux
2009-11-20 15:01 ` Wim Van Sebroeck
2009-11-20 17:09 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091123235012.GK18142@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).