From: schindele@nentec.de (Juergen Schindele)
To: linux-arm-kernel@lists.infradead.org
Subject: IXP425: help on HSS channelized service
Date: Thu, 26 Nov 2009 17:44:50 +0200 [thread overview]
Message-ID: <200911261644.51155.schindele@nentec.de> (raw)
In-Reply-To: <20091126144956.GA7150@n2100.arm.linux.org.uk>
Am Donnerstag, 26. November 2009 schrieb Russell King - ARM Linux:
> On Thu, Nov 26, 2009 at 04:43:07PM +0200, Juergen Schindele wrote:
> > Am Mittwoch, 25. November 2009 schrieb Krzysztof Halasa:
> > > The buffers have different structures for RX and TX.
> > This was a very good hint :-). I discovered that the
> > "struct desc" used in the kernel mainline driver is quite
> > different from the one used in INTEL code !?????.
> > When I replace the "struct desc" (see below) it works fine for me.
> > Isn't there a general problem with this driver when it works only
> > for channelized mode (your case) ???
> > Has sombody made it working in HDLC_PIPE mode ????
> >
> > here my changes:
> > I replaced
> >
> > struct desc {
> > u32 next; /* pointer to next buffer, unused */
> >
> > #ifdef __ARMEB__
> > u16 buf_len; /* buffer length */
> > u16 pkt_len; /* packet length */
> > u32 data; /* pointer to data buffer in RAM */
> > u8 status;
> > u8 error_count;
> > u16 __reserved;
> > #else
> > u16 pkt_len; /* packet length */
> > u16 buf_len; /* buffer length */
> > u32 data; /* pointer to data buffer in RAM */
> > u16 __reserved;
> > u8 error_count;
> > u8 status;
> > #endif
> > u32 __reserved1[4];
>
> If these structures are sensitive to the byte-endian, they should be
> defined using [bl]e(32|16|8) so that sparse can check that you're
> using appropriate cpu_to_xxx() and xxx_to_cpu() endian conversions on
> them.
Thanks for your information. I can include "linux/types.h"
where are defined these typedefs (i think its what you mean):
typedef __u16 __bitwise __le16;
typedef __u16 __bitwise __be16;
typedef __u32 __bitwise __le32;
typedef __u32 __bitwise __be32;
but where are these ????
typedef __u8 __bitwise __le8;
typedef __u8 __bitwise __be8;
are they missing or am _I_ missing something ???
--------------------------------------------------------------
J?rgen Schindele
Software-Entwicklung
NENTEC Netzwerktechnologie GmbH
Greschbachstr. 12
76229 Karlsruhe
Deutschland
Telefon: +49 721 94249-51
Telefax: +49 721 94249-10
E-Mail: schindele at nentec.de
WEB: www.nentec.de
Gesch?ftsf?hrung: Klaus Becker, Roland Knapp
Sitz der Gesellschaft: Karlsruhe
Handelsregister: Amtsgericht Mannheim HRB 107658
--------------------------------------------------------------
next prev parent reply other threads:[~2009-11-26 15:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 13:29 IXP425: help on HSS channelized service Davide Di Gesualdo
2009-11-24 15:22 ` Juergen Schindele
2009-11-25 0:07 ` Krzysztof Halasa
2009-11-25 12:52 ` Davide Di Gesualdo
2009-11-24 23:45 ` Krzysztof Halasa
2009-11-26 14:43 ` Juergen Schindele
2009-11-26 14:49 ` Russell King - ARM Linux
2009-11-26 15:44 ` Juergen Schindele [this message]
2009-11-26 15:51 ` Russell King - ARM Linux
2009-11-26 19:03 ` Krzysztof Halasa
2009-11-26 19:39 ` Krzysztof Halasa
2009-11-27 8:21 ` Juergen Schindele
2009-11-27 23:55 ` Krzysztof Halasa
2009-11-30 8:18 ` Juergen Schindele
-- strict thread matches above, loose matches on Subject: below --
2009-11-25 13:34 Davide Di Gesualdo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911261644.51155.schindele@nentec.de \
--to=schindele@nentec.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).