From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 16/17] ALSA: ARM: add Raumfeld audio support
Date: Thu, 26 Nov 2009 18:51:50 +0100 [thread overview]
Message-ID: <20091126175150.GK14091@buzzloop.caiaq.de> (raw)
In-Reply-To: <20091125132912.GB14045@rakim.wolfsonmicro.main>
On Wed, Nov 25, 2009 at 01:29:13PM +0000, Mark Brown wrote:
> On Wed, Nov 25, 2009 at 01:24:36PM +0100, Daniel Mack wrote:
> > No, it wasn't.
>
> There was at least one unrelated driver for a different part - I
> remember the discussion since someone needed to explain to people (Alan
> Cox, I think) that this wasn't an RTC but rather a TDM clock generator.
>
> > http://marc.info/?l=linux-i2c&m=122457836326525&w=2
>
> > Jean Delvare's last comment on this was:
>
> > > Honestly I don't see any value in this driver. There's nothing you can
> > > do with it that you couldn't already do without it.
>
> > The driver itself would do the right thing, but I doubt that
> > resubmitting will help much.
>
> Looking at the thread in the archive I don't see any effort to answer
> Jean's question there - the reply from Jon talks about device tree
> binding which is, as Jean says, pretty much irrelevant to the question:
>
> http://marc.info/?l=linux-i2c&m=122465761327694&w=2
>
> The question seemed to be more about what the driver was supposed to
> accomplish - talking about the functionality is provided by the driver
> once it's bound to the device should address that.
Ok, will probably get back to this later. For now, I left the code where
it was but changed the API to make it clearer. The actual implementation
is in one line only, so I see no urgent need to move it to an own driver
immediately. Let me know if you're fine with the new version I'll post
soon.
Thanks,
Daniel
next prev parent reply other threads:[~2009-11-26 17:51 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 10:42 ARM: pxa: add support for Raumfeld audio devices Daniel Mack
2009-11-25 10:42 ` [PATCH 01/17] ARM: pxa/raumfeld: add basic structure for devices Daniel Mack
2009-11-25 15:26 ` Mike Rapoport
2009-11-25 15:44 ` Daniel Mack
2009-11-25 16:51 ` Marek Vasut
2009-11-25 17:06 ` Russell King - ARM Linux
2009-11-25 10:42 ` [PATCH 02/17] ARM: pxa/raumfeld: add GPIO definitions Daniel Mack
2009-11-25 10:42 ` [PATCH 03/17] ARM: pxa/raumfeld: add SMSC9220 ethernet support Daniel Mack
2009-11-25 15:26 ` Mike Rapoport
2009-11-25 15:49 ` Daniel Mack
2009-11-25 16:56 ` Russell King - ARM Linux
2009-11-26 17:55 ` Daniel Mack
2009-11-25 10:42 ` [PATCH 04/17] ARM: pxa/raumfeld: add OHCI function Daniel Mack
2009-11-25 10:42 ` [PATCH 05/17] ARM: pxa/raumfeld: add rotary encoder support Daniel Mack
2009-11-25 15:26 ` Mike Rapoport
2009-11-25 15:50 ` Daniel Mack
2009-11-25 16:59 ` Russell King - ARM Linux
2009-11-25 10:42 ` [PATCH 06/17] ARM: pxa/raumfeld: add GPIO buttons Daniel Mack
2009-11-25 10:42 ` [PATCH 07/17] ARM: pxa/raumfeld: add GPIO connected LEDs Daniel Mack
2009-11-25 10:42 ` [PATCH 08/17] ARM: pxa/raumfeld: add one-wire function Daniel Mack
2009-11-25 17:02 ` Russell King - ARM Linux
2009-11-25 10:42 ` [PATCH 09/17] ARM: pxa/raumfeld: add NAND partitions Daniel Mack
2009-11-25 15:26 ` Mike Rapoport
2009-11-25 10:42 ` [PATCH 10/17] ARM: pxa/raumfeld: add framebuffer and backlight devices Daniel Mack
2009-11-25 10:42 ` [PATCH 11/17] ARM: pxa/raumfeld: add SPI controlled devices Daniel Mack
2009-11-25 10:42 ` [PATCH 12/17] ARM: pxa/raumfeld: add audio related functions Daniel Mack
2009-11-25 11:41 ` Mark Brown
2009-11-25 12:28 ` Daniel Mack
2009-11-25 13:07 ` Mark Brown
2009-11-25 13:53 ` Daniel Mack
2009-11-25 14:00 ` Mark Brown
2009-11-25 17:07 ` Russell King - ARM Linux
2009-11-25 10:42 ` [PATCH 13/17] ARM: pxa/raumfeld: add Marvell Libertas via SDIO Daniel Mack
2009-11-25 11:49 ` Mark Brown
2009-11-25 13:04 ` Daniel Mack
2009-11-25 13:36 ` Mark Brown
2009-11-25 10:42 ` [PATCH 14/17] ARM: pxa/raumfeld: add power supply framework Daniel Mack
2009-11-25 10:42 ` [PATCH 15/17] ARM: pxa/raumfeld: add support for I2C controlled devices Daniel Mack
2009-11-25 10:42 ` [PATCH 16/17] ALSA: ARM: add Raumfeld audio support Daniel Mack
2009-11-25 11:02 ` Mark Brown
2009-11-25 12:24 ` Daniel Mack
2009-11-25 13:29 ` Mark Brown
2009-11-26 17:51 ` Daniel Mack [this message]
2009-11-25 10:42 ` [PATCH 17/17] ARM: pxa/raumfeld: Add defconfig Daniel Mack
2009-11-25 11:27 ` ARM: pxa: add support for Raumfeld audio devices Mike Rapoport
2009-11-25 12:14 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091126175150.GK14091@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).