From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ALSA: ARM: add Raumfeld audio support
Date: Fri, 27 Nov 2009 13:42:21 +0100 [thread overview]
Message-ID: <20091127124221.GS14091@buzzloop.caiaq.de> (raw)
In-Reply-To: <20091127113449.GB29821@rakim.wolfsonmicro.main>
On Fri, Nov 27, 2009 at 11:34:49AM +0000, Mark Brown wrote:
> On Thu, Nov 26, 2009 at 06:59:00PM +0100, Daniel Mack wrote:
>
> > +static struct regulator_consumer_supply audio_va_consumer_supply =
> > + REGULATOR_SUPPLY("va", "soc-audio.0");
>
> I hadn't spotted this in your cs4270 patches but the device used should
> be the I2C device, not the soc-audio device. I'd also expect to see
> this regulator setup done in arch/arm - the stuff I'd expect to see in
> here is the resource claiming stuff. Having it here is also fine, it's
> just a little surprising.
Ok, all done. See the v3 spin I'll post now.
Thanks,
Daniel
next prev parent reply other threads:[~2009-11-27 12:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 17:58 ARM: pxa: add support for Raumfeld audio devices [v2] Daniel Mack
2009-11-26 17:58 ` [PATCH 1/3] ARM: pxa/raumfeld: add platform support Daniel Mack
2009-11-26 17:59 ` [PATCH 2/3] ALSA: ARM: add Raumfeld audio support Daniel Mack
2009-11-26 17:59 ` [PATCH 3/3] ARM: pxa/raumfeld: Add defconfig Daniel Mack
2009-11-27 11:34 ` [PATCH 2/3] ALSA: ARM: add Raumfeld audio support Mark Brown
2009-11-27 12:42 ` Daniel Mack [this message]
2009-11-26 19:13 ` [PATCH 1/3] ARM: pxa/raumfeld: add platform support Marek Vasut
2009-11-26 19:17 ` Daniel Mack
2009-11-26 19:18 ` Russell King - ARM Linux
2009-11-26 22:11 ` Marek Vasut
2009-11-26 22:19 ` Russell King - ARM Linux
2009-11-27 1:49 ` Marek Vasut
2009-11-27 8:50 ` Russell King - ARM Linux
2009-11-27 5:46 ` Eric Miao
2009-11-27 10:27 ` Daniel Mack
-- strict thread matches above, loose matches on Subject: below --
2009-11-27 12:47 ARM: pxa: add support for Raumfeld audio devices [v3] Daniel Mack
2009-11-27 12:47 ` [PATCH 1/3] ARM: pxa/raumfeld: add platform support Daniel Mack
2009-11-27 12:47 ` [PATCH 2/3] ALSA: ARM: add Raumfeld audio support Daniel Mack
2009-11-27 16:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091127124221.GS14091@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).