From mboxrd@z Thu Jan  1 00:00:00 1970
From: daniel@caiaq.de (Daniel Mack)
Date: Fri, 27 Nov 2009 13:42:21 +0100
Subject: [PATCH 2/3] ALSA: ARM: add Raumfeld audio support
In-Reply-To: <20091127113449.GB29821@rakim.wolfsonmicro.main>
References: <1259258341-31114-1-git-send-email-daniel@caiaq.de>
	<1259258341-31114-2-git-send-email-daniel@caiaq.de>
	<1259258341-31114-3-git-send-email-daniel@caiaq.de>
	<20091127113449.GB29821@rakim.wolfsonmicro.main>
Message-ID: <20091127124221.GS14091@buzzloop.caiaq.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Fri, Nov 27, 2009 at 11:34:49AM +0000, Mark Brown wrote:
> On Thu, Nov 26, 2009 at 06:59:00PM +0100, Daniel Mack wrote:
> 
> > +static struct regulator_consumer_supply audio_va_consumer_supply =
> > +	REGULATOR_SUPPLY("va", "soc-audio.0");
> 
> I hadn't spotted this in your cs4270 patches but the device used should
> be the I2C device, not the soc-audio device.  I'd also expect to see
> this regulator setup done in arch/arm - the stuff I'd expect to see in
> here is the resource claiming stuff.  Having it here is also fine, it's
> just a little surprising.

Ok, all done. See the v3 spin I'll post now.

Thanks,
Daniel