From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] S3C6410: Correct names of IISv4 data output pin definitions
Date: Tue, 1 Dec 2009 18:16:45 +0000 [thread overview]
Message-ID: <20091201181644.GK4808@trinity.fluff.org> (raw)
In-Reply-To: <1259340239-12067-2-git-send-email-broonie@opensource.wolfsonmicro.com>
On Fri, Nov 27, 2009 at 04:43:54PM +0000, Mark Brown wrote:
> The naming of the defines suggests that there are three IISv4 ports
> with one data line each when in fact there is a single IISv4 port
> with three data lines.
ok, will sort this out.
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> arch/arm/plat-s3c64xx/include/plat/gpio-bank-c.h | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-s3c64xx/include/plat/gpio-bank-c.h b/arch/arm/plat-s3c64xx/include/plat/gpio-bank-c.h
> index c47daf7..e22b49f 100644
> --- a/arch/arm/plat-s3c64xx/include/plat/gpio-bank-c.h
> +++ b/arch/arm/plat-s3c64xx/include/plat/gpio-bank-c.h
> @@ -36,18 +36,18 @@
>
> #define S3C64XX_GPC4_SPI_MISO1 (0x02 << 16)
> #define S3C64XX_GPC4_MMC2_CMD (0x03 << 16)
> -#define S3C64XX_GPC4_I2S0_V40_DO (0x05 << 16)
> +#define S3C64XX_GPC4_I2S_V40_DO0 (0x05 << 16)
> #define S3C64XX_GPC4_EINT_G2_4 (0x07 << 16)
>
> #define S3C64XX_GPC5_SPI_CLK1 (0x02 << 20)
> #define S3C64XX_GPC5_MMC2_CLK (0x03 << 20)
> -#define S3C64XX_GPC5_I2S1_V40_DO (0x05 << 20)
> +#define S3C64XX_GPC5_I2S_V40_DO1 (0x05 << 20)
> #define S3C64XX_GPC5_EINT_G2_5 (0x07 << 20)
>
> #define S3C64XX_GPC6_SPI_MOSI1 (0x02 << 24)
> #define S3C64XX_GPC6_EINT_G2_6 (0x07 << 24)
>
> #define S3C64XX_GPC7_SPI_nCS1 (0x02 << 28)
> -#define S3C64XX_GPC7_I2S2_V40_DO (0x05 << 28)
> +#define S3C64XX_GPC7_I2S_V40_DO2 (0x05 << 28)
> #define S3C64XX_GPC7_EINT_G2_7 (0x07 << 28)
>
> --
> 1.6.5.3
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2009-12-01 18:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 16:43 [PATCH 0/7] S3C64XX IISv4 support Mark Brown
2009-11-27 16:43 ` [PATCH 1/7] S3C64XX: Staticise platform data for PCM devices Mark Brown
2009-11-28 1:40 ` jassi brar
2009-12-01 18:08 ` Ben Dooks
2009-12-02 0:22 ` jassi brar
2009-12-03 22:01 ` Ben Dooks
2009-12-03 22:57 ` Mark Brown
2009-11-27 16:43 ` [PATCH 2/7] S3C6410: Correct names of IISv4 data output pin definitions Mark Brown
2009-12-01 18:16 ` Ben Dooks [this message]
2009-11-27 16:43 ` [PATCH 3/7] S3C64XX: Add support for CLK_SRC2 configured clocks Mark Brown
2009-11-28 1:46 ` jassi brar
2009-12-01 18:17 ` Ben Dooks
2009-11-27 16:43 ` [PATCH 4/7] S3C64XX: Declare IISv4 PCLK for S3C6410 Mark Brown
2009-12-01 21:42 ` Ben Dooks
2009-12-02 0:50 ` jassi brar
2009-12-02 12:10 ` Mark Brown
2009-12-04 13:17 ` jassi brar
2009-12-02 11:20 ` Mark Brown
2009-11-27 16:43 ` [PATCH 5/7] S3C6410: Define CLK_AUDIO2 for IISv4 block Mark Brown
2009-11-27 16:43 ` [PATCH 6/7] S3C6410: Use platform data to supply pin configuration for IISv4 Mark Brown
2009-11-28 1:31 ` jassi brar
2009-12-01 18:24 ` Ben Dooks
2009-11-27 16:43 ` [PATCH 7/7] SMDK6410: Register IISv4 device Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091201181644.GK4808@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).