linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MMC: pxamci: call pdata->setpower even when regulator is used
Date: Wed, 2 Dec 2009 01:52:17 +0100	[thread overview]
Message-ID: <20091202005217.GT14091@buzzloop.caiaq.de> (raw)
In-Reply-To: <1259233813-2724-1-git-send-email-daniel@caiaq.de>

ping.

On Thu, Nov 26, 2009 at 12:10:13PM +0100, Daniel Mack wrote:
> On platforms where the vmmc regulator is used, it might still be
> necessary to call the platform data's setpower() callback in order to
> drive GPIOs to power up hardware.
> 
> I can't see any pxamci user with power regulators enabled, hence this
> shouldn't break anything.
> 
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Cc: Pierre Ossman <pierre@ossman.eu>
> Cc: Eric Miao <eric.y.miao@gmail.com>
> Cc: linux-mmc at vger.kernel.org
> ---
>  drivers/mmc/host/pxamci.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
> index b00d673..c35df2b 100644
> --- a/drivers/mmc/host/pxamci.c
> +++ b/drivers/mmc/host/pxamci.c
> @@ -84,7 +84,7 @@ static inline void pxamci_init_ocr(struct pxamci_host *host)
>  		host->mmc->ocr_avail = mmc_regulator_get_ocrmask(host->vcc);
>  		if (host->pdata && host->pdata->ocr_mask)
>  			dev_warn(mmc_dev(host->mmc),
> -				"ocr_mask/setpower will not be used\n");
> +				"given ocr_mask will not be used\n");
>  	}
>  #endif
>  	if (host->vcc == NULL) {
> @@ -109,7 +109,7 @@ static inline void pxamci_set_power(struct pxamci_host *host, unsigned int vdd)
>  		gpio_set_value(host->pdata->gpio_power,
>  			       !!on ^ host->pdata->gpio_power_invert);
>  	}
> -	if (!host->vcc && host->pdata && host->pdata->setpower)
> +	if (host->pdata && host->pdata->setpower)
>  		host->pdata->setpower(mmc_dev(host->mmc), vdd);
>  }
>  
> -- 
> 1.6.5.2
> 

  reply	other threads:[~2009-12-02  0:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-26 11:10 [PATCH] MMC: pxamci: call pdata->setpower even when regulator is used Daniel Mack
2009-12-02  0:52 ` Daniel Mack [this message]
2009-12-02  4:34 ` Eric Miao
2010-08-27 19:00 ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091202005217.GT14091@buzzloop.caiaq.de \
    --to=daniel@caiaq.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).