From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@caiaq.de (Daniel Mack) Date: Wed, 2 Dec 2009 12:03:26 +0100 Subject: [PATCH] mmc: pxamci: call mmc_remove_host() before freeing resources In-Reply-To: References: <1259687838-31722-1-git-send-email-daniel@caiaq.de> Message-ID: <20091202110326.GZ14091@buzzloop.caiaq.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Dec 02, 2009 at 08:50:44AM +0800, Eric Miao wrote: > On Wed, Dec 2, 2009 at 1:17 AM, Daniel Mack wrote: > > mmc_remove_host() will cause the mmc core to switch off the bus power by > > eventually calling pxamci_set_ios(). This function uses the regulator or > > the GPIO which have been freed already. > > > > This causes the following Oops on module unload. > > [...] > > > > Signed-off-by: Daniel Mack > > Reported-by: Sven Neumann > > Cc: Pierre Ossman > > Cc: Eric Miao > > Cc: linux-mmc at vger.kernel.org > > Cc: linux-arm-kernel at lists.infradead.org > > Cc: stable at kernel.org > > --- > > ?drivers/mmc/host/pxamci.c | ? ?4 ++-- > > Looks like a correct fix to me. > > Acked-by: Eric Miao Would be good to still get this into .32 - who will take care of picking this?