linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] leds: Add LED class driver for regulator driven LEDs.
Date: Fri, 4 Dec 2009 12:45:05 +0000	[thread overview]
Message-ID: <20091204124505.GA3320@sirena.org.uk> (raw)
In-Reply-To: <20091204133943.ddf0e53d.ospite@studenti.unina.it>

On Fri, Dec 04, 2009 at 01:39:43PM +0100, Antonio Ospite wrote:
> Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> > You almost certainly want regulator_get_exclusive() here; this driver
> > can't function properly if something else is using the regulator and
> > holding the LED on or off without it.  You'll also want to check the
> > status of the LED on startup and update your internal status to match
> > that.

> When you refer to "the status of the LED on startup" do you mean a
> initial brightness value passed via leds-regulator platform data, or the
> initial status or the regulator itself?

The hardware state at startup; I would imagine that you'd want to make
setting the initial state via platform data optional in order to enable
a smooth handover from bootloader to Linux where the state may depend on
the runtime state (eg, charging indication).

  reply	other threads:[~2009-12-04 12:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1259775625-25973-1-git-send-email-ospite@studenti.unina.it>
2009-12-02 18:06 ` [PATCH] leds: Add LED class driver for regulator driven LEDs Mark Brown
2009-12-02 20:25   ` Antonio Ospite
2009-12-02 20:40     ` Mark Brown
2009-12-02 20:48       ` Antonio Ospite
2009-12-04 12:39   ` Antonio Ospite
2009-12-04 12:45     ` Mark Brown [this message]
2009-12-02 18:23 ` Liam Girdwood
2009-12-02 20:31   ` Antonio Ospite
2009-12-02 20:41     ` Mark Brown
2009-12-04 12:57       ` Antonio Ospite
2009-12-07 11:49         ` Mark Brown
     [not found] ` <1260194893-30149-1-git-send-email-ospite@studenti.unina.it>
2009-12-15 10:22   ` [PATCH v2] " Antonio Ospite
2009-12-15 10:58   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091204124505.GA3320@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).