From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 09/09] regulator: refresh 88pm8607 driver with updated api
Date: Wed, 9 Dec 2009 15:20:27 +0000 [thread overview]
Message-ID: <20091209152026.GD32223@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <771cded00912090518s29c295a9v7f555a543f3bc4e6@mail.gmail.com>
On Wed, Dec 09, 2009 at 08:18:18AM -0500, Haojian Zhuang wrote:
> Since i2c API of mfd 88pm860x driver is changed, refresh 88pm8607 driver.
> Remove the support of 88PM8607 A0/A1 stepping.
> Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
Might be nice to split the removal of the old devices into a separate
patch but that is definitely a win. One blocker below, though.
> + ret = (index < 3) ? (index * 50000 + 1800000) :
> + ((index < 7) ? (index * 50000 + 2550000) :
> + 3300000);
I know the previous code did this but I'm really not loving the multiple
ternery operators here for legibility.
> return 0;
> }
> -subsys_initcall(pm8607_regulator_init);
> +module_init(pm8607_regulator_init);
This should be left at subsys_initcall() to try to ensure that the
regulators are initialsied before the things that use them, otherwise
the handling of init sequencing gets too complex.
next prev parent reply other threads:[~2009-12-09 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 13:18 [PATCH v2 09/09] regulator: refresh 88pm8607 driver with updated api Haojian Zhuang
2009-12-09 15:20 ` Mark Brown [this message]
2009-12-10 3:44 ` Haojian Zhuang
2009-12-10 10:31 ` Mark Brown
2009-12-15 15:07 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091209152026.GD32223@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).