From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 07/09] led: enable led in 88pm860x
Date: Thu, 10 Dec 2009 18:04:04 +0000 [thread overview]
Message-ID: <20091210180403.GA11889@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <771cded00912091957n7662b62bv519f10ed9f992c75@mail.gmail.com>
On Wed, Dec 09, 2009 at 10:57:59PM -0500, Haojian Zhuang wrote:
> + on = *delay_on;
> + if ((on < LED_BLINK_ON_MIN) || (on > LED_BLINK_ON_MAX))
> + return -EINVAL;
You're returning -EINVAL here but...
> + period = on + *delay_off;
> + if (period < LED_BLINK_PERIOD_MIN)
> + period = LED_BLINK_PERIOD_MIN;
> + if (period > LED_BLINK_PERIOD_MAX)
> + period = LED_BLINK_PERIOD_MAX;
...I'd expect it also here?
prev parent reply other threads:[~2009-12-10 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 13:16 [PATCH V2 07/09] led: enable led in 88pm860x Haojian Zhuang
2009-12-09 15:14 ` Mark Brown
2009-12-10 3:57 ` Haojian Zhuang
2009-12-10 18:04 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210180403.GA11889@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).