From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] mfd: mc13783: Take care of semantic inversion between read and write value of two bits in POWER_MISCELLANEUS register.
Date: Sun, 13 Dec 2009 20:56:07 +0100 [thread overview]
Message-ID: <20091213195606.GA14024@pengutronix.de> (raw)
In-Reply-To: <1260636523.2054.28.camel@climbing-alby>
On Sat, Dec 12, 2009 at 05:48:43PM +0100, Alberto Panizzo wrote:
> MC13783_REGCTRL_PWGTnSPIEN controls the states of the corresponding
> PWGTn_DRV output.
> Reading 1 on the corresponding bit mean that the output is enabled
> Writing 1 on the corresponding bit disable that output!
>
> So, if not asked directly to modify those bits, write the inverted
> value.
Hmm, I'm not sure this completely right. The Spec has:
Bit PWGTxSPIEN | Pin PWGTxEN | PWGTxDRV | Read Back
0 = default | | | PWGTxSPIEN
---------------+-------------+----------+------------
1 | x | Low | 0
0 | 0 | High | 1
0 | 1 | Low | 0
So it looks a bit harder than just inverting the read bit.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2009-12-13 19:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 16:37 [PATCH 0/4] Patch series for introduce voltage selecting for mc13783 regulators Alberto Panizzo
2009-12-12 16:48 ` [PATCH 1/4] mfd: mc13783: Take care of semantic inversion between read and write value of two bits in POWER_MISCELLANEUS register Alberto Panizzo
2009-12-12 16:53 ` [PATCH 2/4] mfd: mc13783: When probing, unlock the mc13783 before subsystems initialisation Alberto Panizzo
2009-12-12 16:56 ` [PATCH 3/4] regulator: add voltage selection capability to mc13783 regulators Alberto Panizzo
2009-12-12 17:06 ` [PATCH 4/4] regulator: mc13783 change to platform_driver_register Alberto Panizzo
2009-12-12 18:23 ` Mark Brown
2009-12-13 20:05 ` Uwe Kleine-König
2009-12-14 10:59 ` Alberto Panizzo
2009-12-12 18:22 ` [PATCH 3/4] regulator: add voltage selection capability to mc13783 regulators Mark Brown
2009-12-13 20:01 ` Uwe Kleine-König
2009-12-14 10:41 ` Alberto Panizzo
2009-12-14 11:04 ` Mark Brown
2009-12-13 19:57 ` [PATCH 2/4] mfd: mc13783: When probing, unlock the mc13783 before subsystems initialisation Uwe Kleine-König
2009-12-12 18:11 ` [PATCH 1/4] mfd: mc13783: Take care of semantic inversion between read and write value of two bits in POWER_MISCELLANEUS register Mark Brown
2009-12-13 19:56 ` Uwe Kleine-König [this message]
2009-12-14 10:14 ` Alberto Panizzo
-- strict thread matches above, loose matches on Subject: below --
2009-12-14 16:41 [PATCH 0/4 v2] Patch series for introduce voltage selecting for mc13783 regulators Alberto Panizzo
2009-12-14 17:12 ` [PATCH 1/4] mfd: mc13783: Take care of semantic inversion between read and write value of two bits in POWER_MISCELLANEUS register Alberto Panizzo
[not found] ` <4B26799F.1020507@ru.mvista.com>
2009-12-14 17:59 ` Alberto Panizzo
2010-01-05 18:15 ` Samuel Ortiz
2010-01-05 19:55 ` Uwe Kleine-König
2010-01-08 10:53 ` Alberto Panizzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091213195606.GA14024@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).