From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] Remove suspend/resume functionality, add dynamic clocking
Date: Tue, 15 Dec 2009 11:36:08 +0100 [thread overview]
Message-ID: <20091215103608.GE17930@elf.ucw.cz> (raw)
In-Reply-To: <083DF309106F364B939360100EC290F804F57A69FA@eu1rdcrdc1wx030.exi.nxp.com>
> > > > Are you sure its unneeded? What if someone attempts to suspend the
> > > > system when a transaction is running?
> > > That's exactly my question. I think the machine will suspend and the
> > > transaction fail. So no suspend callback isn't optimal, but maybe OK?!
> >
> > Having failures just because suspend happened at wrong time is
> > bad. .suspend() should just wait for end of transaction.
>
> I'm not sure what situation could actually occur that would suspend the
> system in the middle of an I2C transaction. If an I2C transaction was
> started and the CPU was suspended, this would appear to be a problem
> outside the I2C driver itself. Would other I2C drivers have this similar
> problem?
Well, can the i2c transaction sleep? If so, suspend probably can come
in the middle.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-12-15 10:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 21:23 [PATCH 1/1] Remove suspend/resume functionality, add dynamic clocking Kevin Wells
2009-11-26 9:02 ` Uwe Kleine-König
2009-11-26 10:41 ` Russell King - ARM Linux
2009-11-30 17:02 ` Kevin Wells
2009-12-06 8:47 ` Pavel Machek
2009-12-06 21:02 ` Uwe Kleine-König
2009-12-06 21:08 ` Pavel Machek
2009-12-07 19:21 ` Kevin Wells
2009-12-15 10:36 ` Pavel Machek [this message]
2009-11-30 23:19 ` Russell King - ARM Linux
2009-12-01 18:25 ` Kevin Wells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091215103608.GE17930@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).