From: paul@pwsan.com (Paul Walmsley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] OMAP clock: remove incorrect EXPORT_SYMBOL()s
Date: Thu, 17 Dec 2009 21:20:24 -0700 [thread overview]
Message-ID: <20091218042022.27280.12285.stgit@localhost.localdomain> (raw)
In-Reply-To: <20091218041912.27280.92152.stgit@localhost.localdomain>
The only symbols that should be exported are symbols that are to be
called from loadable kernel modules, e.g., device drivers. In the
context of plat-omap/clock.c, these should only be the Linux clock
interface symbols as defined by include/linux/clk.h. Core code
doesn't need these symbols to be exported. Also, clean up an old
comment while here.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
arch/arm/plat-omap/clock.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/arch/arm/plat-omap/clock.c b/arch/arm/plat-omap/clock.c
index 89cafc9..a64d84c 100644
--- a/arch/arm/plat-omap/clock.c
+++ b/arch/arm/plat-omap/clock.c
@@ -36,10 +36,6 @@ static struct clk_functions *arch_clock;
* Standard clock functions defined in include/linux/clk.h
*-------------------------------------------------------------------------*/
-/* This functions is moved to arch/arm/common/clkdev.c. For OMAP4 since
- * clock framework is not up , it is defined here to avoid rework in
- * every driver. Also dummy prcm reset function is added */
-
int clk_enable(struct clk *clk)
{
unsigned long flags;
@@ -305,7 +301,6 @@ void clk_enable_init_clocks(void)
clk_enable(clkp);
}
}
-EXPORT_SYMBOL(clk_enable_init_clocks);
/*
* Low level helpers
@@ -334,7 +329,6 @@ void clk_init_cpufreq_table(struct cpufreq_frequency_table **table)
arch_clock->clk_init_cpufreq_table(table);
spin_unlock_irqrestore(&clockfw_lock, flags);
}
-EXPORT_SYMBOL(clk_init_cpufreq_table);
#endif
/*-------------------------------------------------------------------------*/
prev parent reply other threads:[~2009-12-18 4:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 4:20 [PATCH 0/8] OMAP clock & IO mapping fixes for 2.6.33-rc2 Paul Walmsley
2009-12-18 4:20 ` [PATCH 1/8] OMAP2: remove duplicated #include Paul Walmsley
2009-12-18 4:20 ` [PATCH 2/8] ARM: OMAP3: PM: Fix the Invalid CM_CLKSTCTRL reg access Paul Walmsley
2009-12-18 4:20 ` [PATCH 3/8] OMAP2xxx IO mapping: mark DSP mappings as being 2420-only Paul Walmsley
2009-12-18 4:20 ` [PATCH 4/8] OMAP2420 IO mapping: move IVA mapping virtual address out of vmalloc space Paul Walmsley
2009-12-18 4:20 ` [PATCH 5/8] OMAP3: clock: add clockdomains for UART1 & 2 Paul Walmsley
2009-12-18 4:20 ` [PATCH 6/8] OMAP3 clock: McBSP 2, 3, 4 functional clock parent is PER_96M_FCLK, not CORE_96M_FCLK Paul Walmsley
2009-12-18 4:20 ` [PATCH 7/8] OMAP3 clock: Add capability to change rate of dpll4_m5_ck Paul Walmsley
2009-12-18 4:20 ` Paul Walmsley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091218042022.27280.12285.stgit@localhost.localdomain \
--to=paul@pwsan.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).