linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jamie@shareable.org (Jamie Lokier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Valid relocation symbol for FLAT format on ARM
Date: Wed, 30 Dec 2009 18:49:29 +0000	[thread overview]
Message-ID: <20091230184929.GB22469@shareable.org> (raw)
In-Reply-To: <52886e760912300830n2234e01bm2e300828141d226@mail.gmail.com>

Jun Sun wrote:
>    (Sent to linux-kernel, but seems nobody cared. Hopefully someone here
>    can pick it up)

I've included uclinux-dev at uclinux.org, because that's where I've seen
most discussion of FLAT format in general.

>    Apparently newer GCC would generate ANCHOR symbols beyond the end of
>    data/bss segment on ARM CPUs. As a result, the exiting validity checking
>    for relocation symbols in FLAT format will fail for some programs.

> -#define        flat_reloc_valid(reloc, size)           ((reloc) <= (size))
> +#define        flat_reloc_valid(reloc, size)           ((reloc) <= (size) + 0x1000)

Why 0x1000?  Is that an arbitrary number, or does it have a specific
meaning for GCC?

>    This also fixes a cosmetic error in printk. Text segment and data/bss
>    segment are allocated from two different areas. It is not meaningful to
>    give the diff between them in error reporting messages.

That part looks fine to me.

-- Jamie

ps. Russell, proof that someone is using no-MMU ARM? :-)
I'll get back to your earlier mail on that subject when I have more time, btw.

  reply	other threads:[~2009-12-30 18:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-30 16:30 [PATCH] Valid relocation symbol for FLAT format on ARM Jun Sun
2009-12-30 18:49 ` Jamie Lokier [this message]
2009-12-31  5:45   ` Jun Sun
2010-01-01 20:46   ` Russell King - ARM Linux
2010-01-01 21:01     ` Russell King - ARM Linux
2010-01-02 17:26     ` Jun Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091230184929.GB22469@shareable.org \
    --to=jamie@shareable.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).