From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] omap fixes for 2.6.33-rc3
Date: Sat, 9 Jan 2010 09:28:41 -0800 [thread overview]
Message-ID: <20100109172841.GF2879@atomide.com> (raw)
In-Reply-To: <20100109134731.a1bca240.sfr@canb.auug.org.au>
* Stephen Rothwell <sfr@canb.auug.org.au> [100108 18:45]:
> Hi Tony,
>
> On Fri, 8 Jan 2010 14:50:23 -0800 Tony Lindgren <tony@atomide.com> wrote:
> >
> > Hmm, sounds like it might make sense to check for that in Stephen's
> > for-next tree then. Added Stephen to the loop, let's see if what he
> > thinks.
>
> I can certainly add hooks to my tree if someone can suggest what should
> be in them (I didn't get enough context here ...). That way I could send
> the tree maintainer a warning email letting them know something is
> fishy ...
Just trying to warn about unconfigured environment for GIT_AUTHOR_EMAIL
and GIT_COMMITTER_EMAIL that makes commits show from user at hostname.(none).
There are quite a few of them, but looks like none after v2.6.33-rc1.
So I guess the test would be to do a pull into for-next, then do a
git log of the pull to see if there were any unconfigured email
addresses. Then notify the maintainers if there were .(none) type
email addresses.
The git commands to test for these would be something like this:
ORIG=$(git log --pretty=format:"%H" -n1)
git pull whatevever
...
git log --pretty=format:"Bad author: %H %ae" --author=".(none)" $ORIG..HEAD
git log --pretty=format:"Bad committer: %H %ce" --committer=".(none)" $ORIG..HEAD
> Of course, this only helps those who don't mind rebasing their trees,
> right? The non-rebasing tree maintainers should do these checks
> themselves. Maybe we could propogate a suggested (or mandatory) set of
> hooks?
Right, this won't catch all of them, and might be too late in many
cases to fix the issue. But just letting the maintainers know about
issues might be enough to fix the problem.
Regards,
Tony
next prev parent reply other threads:[~2010-01-09 17:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 18:09 [GIT PULL] omap fixes for 2.6.33-rc3 Tony Lindgren
2010-01-08 18:19 ` Linus Torvalds
2010-01-08 18:22 ` Tony Lindgren
2010-01-08 22:05 ` Paul Walmsley
2010-01-08 22:27 ` Tony Lindgren
2010-01-08 22:39 ` Linus Torvalds
2010-01-08 22:50 ` Tony Lindgren
2010-01-09 2:47 ` Stephen Rothwell
2010-01-09 17:28 ` Tony Lindgren [this message]
2010-01-08 18:20 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100109172841.GF2879@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).