From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix uncompress code compile for different defines of static(void)
Date: Wed, 13 Jan 2010 09:49:37 +0100 [thread overview]
Message-ID: <20100113084937.GA19352@pengutronix.de> (raw)
In-Reply-To: <20100113021939.GE2986@atomide.com>
Hello,
On Tue, Jan 12, 2010 at 06:19:40PM -0800, Tony Lindgren wrote:
> Because of the include of the decompress_inflate.c file from
> boot/compress/misc.c, there are different flush() defines:
>
> In file included from arch/arm/boot/compressed/misc.c:249:
> arch/arm/boot/compressed/../../../../lib/decompress_inflate.c:138:29: error: macro "flush" passed 2 arguments, but takes just 0
>
> Fix this by removing the define of flush() in misc.c for
> CONFIG_DEBUG_ICEDCC as it's already defined in mach/uncompress.h,
> and that is being included unconditionally.
>
> Also use a static inline function instead of define
> for mach-mxc and mach-gemini to avoid similar bug
> for those platforms.
As arch/arm/boot/compressed/misc.c is compiled with -Dstatic= and this
is AFAIK the only user of uncompress.h I'd skip "static" and/or add a
comment telling that static is redundant here.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-01-13 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 2:19 [PATCH] ARM: Fix uncompress code compile for different defines of static(void) Tony Lindgren
2010-01-13 8:49 ` Uwe Kleine-König [this message]
2010-01-13 14:26 ` Uwe Kleine-König
2010-01-13 17:14 ` Tony Lindgren
2010-01-13 18:11 ` [PATCH] ARM: Fix uncompress code compile for different definesof static(void) H Hartley Sweeten
2010-01-14 8:29 ` Uwe Kleine-König
2010-01-14 9:15 ` Russell King - ARM Linux
2010-01-14 19:38 ` Tony Lindgren
2010-01-18 10:44 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100113084937.GA19352@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).