* [PATCH] S3C: Remove unneeded __init symbols
@ 2010-01-09 10:04 Nelson Castillo
2010-01-09 21:03 ` Uwe Kleine-König
0 siblings, 1 reply; 6+ messages in thread
From: Nelson Castillo @ 2010-01-09 10:04 UTC (permalink / raw)
To: linux-arm-kernel
Two functions defined with __init are also exported.
Let's remove the __init symbols in order to avoid two warnings.
Signed-off-by: Nelson Castillo <arhuaco@freaks-unidos.net>
---
arch/arm/plat-s3c/dev-nand.c | 2 +-
arch/arm/plat-s3c24xx/devs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-s3c/dev-nand.c b/arch/arm/plat-s3c/dev-nand.c
index 84808cc..a1137a7 100644
--- a/arch/arm/plat-s3c/dev-nand.c
+++ b/arch/arm/plat-s3c/dev-nand.c
@@ -79,7 +79,7 @@ static int __init s3c_nand_copy_set(struct s3c2410_nand_set *set)
return 0;
}
-void __init s3c_nand_set_platdata(struct s3c2410_platform_nand *nand)
+void s3c_nand_set_platdata(struct s3c2410_platform_nand *nand)
{
struct s3c2410_platform_nand *npd;
int size;
diff --git a/arch/arm/plat-s3c24xx/devs.c b/arch/arm/plat-s3c24xx/devs.c
index 7f686a3..267f36a 100644
--- a/arch/arm/plat-s3c24xx/devs.c
+++ b/arch/arm/plat-s3c24xx/devs.c
@@ -193,7 +193,7 @@ EXPORT_SYMBOL(s3c_device_ts);
static struct s3c2410_ts_mach_info s3c2410ts_info;
-void __init s3c24xx_ts_set_platdata(struct s3c2410_ts_mach_info *hard_s3c2410ts_info)
+void s3c24xx_ts_set_platdata(struct s3c2410_ts_mach_info *hard_s3c2410ts_info)
{
memcpy(&s3c2410ts_info, hard_s3c2410ts_info, sizeof(struct s3c2410_ts_mach_info));
s3c_device_ts.dev.platform_data = &s3c2410ts_info;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] S3C: Remove unneeded __init symbols
2010-01-09 10:04 [PATCH] S3C: Remove unneeded __init symbols Nelson Castillo
@ 2010-01-09 21:03 ` Uwe Kleine-König
2010-01-13 14:39 ` Nelson Castillo
0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2010-01-09 21:03 UTC (permalink / raw)
To: linux-arm-kernel
Hi Nelson,
On Sat, Jan 09, 2010 at 05:04:30AM -0500, Nelson Castillo wrote:
> Two functions defined with __init are also exported.
> Let's remove the __init symbols in order to avoid two warnings.
Can you quote the warnings please?
And I thought you agreed that "unneeded" for __init isn't optimal.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] S3C: Remove unneeded __init symbols
2010-01-09 21:03 ` Uwe Kleine-König
@ 2010-01-13 14:39 ` Nelson Castillo
2010-01-13 14:57 ` Uwe Kleine-König
0 siblings, 1 reply; 6+ messages in thread
From: Nelson Castillo @ 2010-01-13 14:39 UTC (permalink / raw)
To: linux-arm-kernel
2010/1/9 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> Hi Nelson,
>
> On Sat, Jan 09, 2010 at 05:04:30AM -0500, Nelson Castillo wrote:
>> Two functions defined with __init are also exported.
>> Let's remove the __init symbols in order to avoid two warnings.
> Can you quote the warnings please?
Done. Patch attached.
> And I thought you agreed that "unneeded" for __init isn't optimal.
I also changed the subject. I don't know if it's optimal but it's
better now IMHO :-P
-------------- next part --------------
A non-text attachment was scrubbed...
Name: s3c-remove-unneeded-init-annotations.patch
Type: text/x-diff
Size: 2176 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100113/c54a46ba/attachment.bin>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] S3C: Remove unneeded __init symbols
2010-01-13 14:39 ` Nelson Castillo
@ 2010-01-13 14:57 ` Uwe Kleine-König
2010-01-13 15:19 ` Nelson Castillo
0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2010-01-13 14:57 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Wed, Jan 13, 2010 at 09:39:11AM -0500, Nelson Castillo wrote:
> 2010/1/9 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> > Hi Nelson,
> >
> > On Sat, Jan 09, 2010 at 05:04:30AM -0500, Nelson Castillo wrote:
> >> Two functions defined with __init are also exported.
> >> Let's remove the __init symbols in order to avoid two warnings.
> > Can you quote the warnings please?
>
> Done. Patch attached.
>
> > And I thought you agreed that "unneeded" for __init isn't optimal.
>
> I also changed the subject. I don't know if it's optimal but it's
> better now IMHO :-P
> From 0253f8900cba96ef1a5a8707ad1934f0a65f052a Mon Sep 17 00:00:00 2001
> From: Nelson Castillo <arhuaco@freaks-unidos.net>
> Date: Wed, 13 Jan 2010 09:33:59 -0500
> Subject: [PATCH] S3C: Fix two warnings caused by __init annotations
>
> The symbols s3c24xx_ts_set_platdata and s3c_nand_set_platdata are
> exported and annotated __init. Let's remove the __init annotations
> to avoid the following warnings:
>
> WARNING: vmlinux.o(__ksymtab+0x428): Section mismatch in
> reference from the variable __ksymtab_s3c24xx_ts_set_platdata
> to the function .init.text:s3c24xx_ts_set_platdata()
> The symbol s3c24xx_ts_set_platdata is exported and annotated __init
> Fix this by removing the __init annotation of s3c24xx_ts_set_platdata
> or drop the export.
>
> WARNING: vmlinux.o(__ksymtab_gpl+0x40): Section mismatch in reference
> from the variable __ksymtab_s3c_nand_set_platdata to the function
> .init.text:s3c_nand_set_platdata()
> The symbol s3c_nand_set_platdata is exported and annotated __init
> Fix this by removing the __init annotation of s3c_nand_set_platdata
> or drop the export.
linux-2.6$ git grep -l -E 's3c(_nand|24xx_ts)_set_platdata'
arch/arm/mach-s3c2410/include/mach/ts.h
arch/arm/mach-s3c2410/mach-bast.c
arch/arm/mach-s3c2410/mach-h1940.c
arch/arm/mach-s3c2410/mach-qt2410.c
arch/arm/mach-s3c2412/mach-jive.c
arch/arm/mach-s3c2412/mach-vstms.c
arch/arm/mach-s3c2440/mach-anubis.c
arch/arm/mach-s3c2440/mach-at2440evb.c
arch/arm/mach-s3c2440/mach-mini2440.c
arch/arm/mach-s3c2440/mach-osiris.c
arch/arm/mach-s3c2440/mach-rx3715.c
arch/arm/mach-s3c2442/mach-gta02.c
arch/arm/mach-s3c6410/mach-hmt.c
arch/arm/plat-s3c/dev-nand.c
arch/arm/plat-s3c/include/plat/nand.h
arch/arm/plat-s3c24xx/common-smdk.c
arch/arm/plat-s3c24xx/devs.c
This doesn't look to used in code that can be compiled as module. So
isn't the more sensible fix to remove EXPORT_SYMBOL?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] S3C: Remove unneeded __init symbols
2010-01-13 14:57 ` Uwe Kleine-König
@ 2010-01-13 15:19 ` Nelson Castillo
2010-01-13 15:34 ` Uwe Kleine-König
0 siblings, 1 reply; 6+ messages in thread
From: Nelson Castillo @ 2010-01-13 15:19 UTC (permalink / raw)
To: linux-arm-kernel
2010/1/13 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> Hello,
>
> On Wed, Jan 13, 2010 at 09:39:11AM -0500, Nelson Castillo wrote:
>> 2010/1/9 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
>> > Hi Nelson,
>> >
>> > On Sat, Jan 09, 2010 at 05:04:30AM -0500, Nelson Castillo wrote:
>> >> Two functions defined with __init are also exported.
>> >> Let's remove the __init symbols in order to avoid two warnings.
>> > Can you quote the warnings please?
>>
>> Done. Patch attached.
>>
>> > And I thought you agreed that "unneeded" for __init isn't optimal.
>>
>> I also changed the subject. I don't know if it's optimal but it's
>> better now IMHO :-P
>
>> From 0253f8900cba96ef1a5a8707ad1934f0a65f052a Mon Sep 17 00:00:00 2001
>> From: Nelson Castillo <arhuaco@freaks-unidos.net>
>> Date: Wed, 13 Jan 2010 09:33:59 -0500
>> Subject: [PATCH] S3C: Fix two warnings caused by __init annotations
>>
>> The symbols s3c24xx_ts_set_platdata and s3c_nand_set_platdata are
>> exported and annotated __init. Let's remove the __init annotations
>> to avoid the following warnings:
>>
>> ?WARNING: vmlinux.o(__ksymtab+0x428): Section mismatch in
>> ?reference from the variable __ksymtab_s3c24xx_ts_set_platdata
>> ?to the function .init.text:s3c24xx_ts_set_platdata()
>> ?The symbol ?s3c24xx_ts_set_platdata is exported and annotated __init
>> ?Fix this by ?removing the __init annotation of s3c24xx_ts_set_platdata
>> ?or drop the ?export.
>>
>> ?WARNING: vmlinux.o(__ksymtab_gpl+0x40): Section mismatch in reference
>> ?from the variable __ksymtab_s3c_nand_set_platdata to the function
>> ?.init.text:s3c_nand_set_platdata()
>> ?The symbol s3c_nand_set_platdata ?is exported and annotated __init
>> ?Fix this by removing the __init ?annotation of s3c_nand_set_platdata
>> ?or drop the export.
>
> ? ? ? ?linux-2.6$ git grep -l -E 's3c(_nand|24xx_ts)_set_platdata'
> ? ? ? ?arch/arm/mach-s3c2410/include/mach/ts.h
> ? ? ? ?arch/arm/mach-s3c2410/mach-bast.c
> ? ? ? ?arch/arm/mach-s3c2410/mach-h1940.c
> ? ? ? ?arch/arm/mach-s3c2410/mach-qt2410.c
> ? ? ? ?arch/arm/mach-s3c2412/mach-jive.c
> ? ? ? ?arch/arm/mach-s3c2412/mach-vstms.c
> ? ? ? ?arch/arm/mach-s3c2440/mach-anubis.c
> ? ? ? ?arch/arm/mach-s3c2440/mach-at2440evb.c
> ? ? ? ?arch/arm/mach-s3c2440/mach-mini2440.c
> ? ? ? ?arch/arm/mach-s3c2440/mach-osiris.c
> ? ? ? ?arch/arm/mach-s3c2440/mach-rx3715.c
> ? ? ? ?arch/arm/mach-s3c2442/mach-gta02.c
> ? ? ? ?arch/arm/mach-s3c6410/mach-hmt.c
> ? ? ? ?arch/arm/plat-s3c/dev-nand.c
> ? ? ? ?arch/arm/plat-s3c/include/plat/nand.h
> ? ? ? ?arch/arm/plat-s3c24xx/common-smdk.c
> ? ? ? ?arch/arm/plat-s3c24xx/devs.c
>
> This doesn't look to used in code that can be compiled as module. ?So
> isn't the more sensible fix to remove EXPORT_SYMBOL?
Grr. Right. I think these functions are not to be used by modules.
New patch attached. Thanks.
Now the word "unneeded" can come back.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: s3c-remove-unneeded-exports.patch
Type: text/x-diff
Size: 2011 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100113/bf728bff/attachment.bin>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] S3C: Remove unneeded __init symbols
2010-01-13 15:19 ` Nelson Castillo
@ 2010-01-13 15:34 ` Uwe Kleine-König
0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2010-01-13 15:34 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Wed, Jan 13, 2010 at 10:19:39AM -0500, Nelson Castillo wrote:
> Grr. Right. I think these functions are not to be used by modules.
> New patch attached. Thanks.
> Now the word "unneeded" can come back.
For-being-such-a-PITA-thanks-to: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
or if you prefer it that way:
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-01-13 15:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-09 10:04 [PATCH] S3C: Remove unneeded __init symbols Nelson Castillo
2010-01-09 21:03 ` Uwe Kleine-König
2010-01-13 14:39 ` Nelson Castillo
2010-01-13 14:57 ` Uwe Kleine-König
2010-01-13 15:19 ` Nelson Castillo
2010-01-13 15:34 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).