[PATCH] ARM: SAMSUNG: Add system.h file

[PATCH] ARM: SAMSUNG: Add system.h file

[Kukjin Kim]

This patch adds system.h file into plat-samsung.

Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
 arch/arm/plat-samsung/include/mach/system.h |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/plat-samsung/include/mach/system.h

diff --git a/arch/arm/plat-samsung/include/mach/system.h b/arch/arm/plat-samsung/include/mach/system.h
new file mode 100644
index 0000000..596fe8d
--- /dev/null
+++ b/arch/arm/plat-samsung/include/mach/system.h
@@ -0,0 +1,26 @@
+/* linux/arch/arm/plat-samsung/include/mach/system.h
+ *
+ * Copyright (c) 2009 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com/
+ *
+ * Idle support
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#ifndef __ASM_PLAT_SYSTEM_H
+#define __ASM_PLAT_SYSTEM_H __FILE__
+
+static void arch_idle(void)
+{
+	/* nothing here yet */
+}
+
+static void arch_reset(char mode, const char *cmd)
+{
+	/* nothing here yet */
+}
+
+#endif /* __ASM_PLAT_SYSTEM_H */
-- 
1.6.2.5

[PATCH] ARM: SAMSUNG: Add system.h file

[Ben Dooks]

On Thu, Jan 14, 2010 at 10:15:14AM +0900, Kukjin Kim wrote:
> This patch adds system.h file into plat-samsung.
> 
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
>  arch/arm/plat-samsung/include/mach/system.h |   26 ++++++++++++++++++++++++++
>  1 files changed, 26 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/plat-samsung/include/mach/system.h
> 
> diff --git a/arch/arm/plat-samsung/include/mach/system.h b/arch/arm/plat-samsung/include/mach/system.h
> new file mode 100644
> index 0000000..596fe8d
> --- /dev/null
> +++ b/arch/arm/plat-samsung/include/mach/system.h
> @@ -0,0 +1,26 @@
> +/* linux/arch/arm/plat-samsung/include/mach/system.h
> + *
> + * Copyright (c) 2009 Samsung Electronics Co., Ltd.
> + *		http://www.samsung.com/
> + *
> + * Idle support
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +#ifndef __ASM_PLAT_SYSTEM_H
> +#define __ASM_PLAT_SYSTEM_H __FILE__
> +
> +static void arch_idle(void)
> +{
> +	/* nothing here yet */
> +}
> +
> +static void arch_reset(char mode, const char *cmd)
> +{
> +	/* nothing here yet */
> +}
> +
> +#endif /* __ASM_PLAT_SYSTEM_H */

ok, but at the moment this is only useful for the s5p6440,all the other
<mach/system.h> implementations have something in them even it is just for
arch_reset().

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

[PATCH] ARM: SAMSUNG: Add system.h file

[Ben Dooks]

On Thu, Jan 14, 2010 at 10:15:14AM +0900, Kukjin Kim wrote:
> This patch adds system.h file into plat-samsung.

My worries here are that this is an empty file that is not currently
useful for any of the extant Samsung SoC in-kernel implementations (they
all have something in their own system.h files) and that if any of the new
architectures decide they need arch_reset() then they may end up overriding
this anyway.
 
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
>  arch/arm/plat-samsung/include/mach/system.h |   26 ++++++++++++++++++++++++++
>  1 files changed, 26 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/plat-samsung/include/mach/system.h
> 
> diff --git a/arch/arm/plat-samsung/include/mach/system.h b/arch/arm/plat-samsung/include/mach/system.h
> new file mode 100644
> index 0000000..596fe8d
> --- /dev/null
> +++ b/arch/arm/plat-samsung/include/mach/system.h
> @@ -0,0 +1,26 @@
> +/* linux/arch/arm/plat-samsung/include/mach/system.h
> + *
> + * Copyright (c) 2009 Samsung Electronics Co., Ltd.
> + *		http://www.samsung.com/
> + *
> + * Idle support
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +#ifndef __ASM_PLAT_SYSTEM_H
> +#define __ASM_PLAT_SYSTEM_H __FILE__
> +
> +static void arch_idle(void)
> +{
> +	/* nothing here yet */
> +}
> +
> +static void arch_reset(char mode, const char *cmd)
> +{
> +	/* nothing here yet */
> +}
> +
> +#endif /* __ASM_PLAT_SYSTEM_H */
> -- 
> 1.6.2.5
> 

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

[PATCH] ARM: SAMSUNG: Add system.h file

[Kukjin Kim]

Ben Dooks wrote:
> On Thu, Jan 14, 2010 at 10:15:14AM +0900, Kukjin Kim wrote:
> > This patch adds system.h file into plat-samsung.
> 
> My worries here are that this is an empty file that is not currently
> useful for any of the extant Samsung SoC in-kernel implementations (they
> all have something in their own system.h files) and that if any of the new
> architectures decide they need arch_reset() then they may end up overriding
> this anyway.

Hi Ben,

Thanks for your comments.
The system.h file is moved to mach-s5p6440/include/mach, in my [PATCH v5 1/8
RE-SEND] patch.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
System LSI Division, SAMSUNG ELECTRONICS CO., LTD.