From: epeer@tmtservices.co.za (Edwin Peer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH - 3rd attempt] ARM: Support for Embedian MXM-8x10 eval kit
Date: Tue, 19 Jan 2010 07:37:59 +0200 [thread overview]
Message-ID: <201001190737.59609.epeer@tmtservices.co.za> (raw)
In-Reply-To: <4B55400C.1050109@tmtservices.co.za>
On Tuesday 19 January 2010 07:15:56 Hennie van der Merwe wrote:
> I originally wrote it like this because I wanted the option for the
> machine implementing the MXM-8x10 module to initialise the MMC or not.
> I'm not sure static is appropriate (as it is exported in the header).
> Could we perhaps drop the inline and just make it a void __init instead?
Indeed, those can't be made static. What I have done is make all the functions
we call in barebones_init() static and remove their declarations from the
header, since those are never optional.
> Agreed. This one must have just slipped by... Too much coffee, not
> enough sleep :)
Fixed. I've also corrected what I hope are the last formatting issues and
fixed one more #include that I somehow missed before.
I'm giving the changes a quick test on the hardware before submitting what I
hope will be the final patch.
Regards,
Edwin Peer
next prev parent reply other threads:[~2010-01-19 5:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 19:34 [PATCH - 3rd attempt] ARM: Support for Embedian MXM-8x10 eval kit Edwin Peer
2010-01-18 21:51 ` Daniel Mack
2010-01-19 5:15 ` Hennie van der Merwe
2010-01-19 5:29 ` Eric Miao
2010-01-19 5:43 ` Hennie van der Merwe
2010-01-19 5:37 ` Edwin Peer [this message]
2010-01-19 5:48 ` Hennie van der Merwe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001190737.59609.epeer@tmtservices.co.za \
--to=epeer@tmtservices.co.za \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).