From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Updated: Fix soft lockup in at91 udc driver
Date: Tue, 19 Jan 2010 09:53:04 +0100 [thread overview]
Message-ID: <20100119085304.GA17708@pengutronix.de> (raw)
In-Reply-To: <4B4F7576.9090008@bluewatersys.com>
Hello,
On Fri, Jan 15, 2010 at 08:50:14AM +1300, Ryan Mallon wrote:
> Fix a potential soft lockup in the AT91 UDC driver by ensuring that the
> UDC clock is enabled inside the interrupt handler. If the UDC clock is
> not enabled then the UDC registers cannot be written to and the
> interrupt cannot be cleared or masked.
Wouldn't it be cleaner to assert that the clock is already on when an
irq comes in? That is enable the clock and let it enabled when
configuring the device to generate irqs?
Just my 2?
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-01-19 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 19:50 [PATCH] Updated: Fix soft lockup in at91 udc driver Ryan Mallon
2010-01-18 20:40 ` Ryan Mallon
2010-01-19 8:53 ` Uwe Kleine-König [this message]
2010-01-19 10:46 ` Remy Bohmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119085304.GA17708@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).