From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] otg Kconfig: let USB_OTG_UTILS select USB_ULPI option
Date: Wed, 20 Jan 2010 20:02:33 +0100 [thread overview]
Message-ID: <20100120190233.GC30066@pengutronix.de> (raw)
In-Reply-To: <1264013508-11247-1-git-send-email-valentin.longchamp@epfl.ch>
On Wed, Jan 20, 2010 at 07:51:48PM +0100, Valentin Longchamp wrote:
> With CONFIG_USB_ULPI=y, CONFIG_USB<=m, CONFIG_PCI=n and
> CONFIG_USB_OTG_UTILS=n, which is the default used for mx31moboard,
> the build of all mx3 platform fails because drivers/usb/otg/ulpi.c
> where otg_ulpi_create is defined is not compiled.
>
> Build error:
> arch/arm/mach-mx3/built-in.o: In function `mxc_board_init':
> kzmarm11.c:(.init.text+0x73c): undefined reference to `otg_ulpi_create'
> kzmarm11.c:(.init.text+0x1020): undefined reference to `otg_ulpi_create'
>
> This isn't a strong dependency as drivers/usb/otg/ulpi.c doesn't
> use functions defined in drivers/usb/otg/otg.o and is only needed
> to get ulpi.o linked into the kernel image.
>
> Signed-off-by: Valentin Longchamp <valentin.longchamp@epfl.ch>
provided you do s/platform/platforms/ above, you get my
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
(Is it better to say "build *for* all mx3 platforms"?)
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-01-20 19:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 17:32 [PATCH] otg Kconfig: add missing select USB_OTG_UTILS to USB_ULPI option Valentin Longchamp
2010-01-18 8:46 ` Uwe Kleine-König
2010-01-20 18:13 ` Valentin Longchamp
2010-01-20 18:26 ` [PATCH] otg Kconfig: select USB_OTG_UTILS wtih " Valentin Longchamp
2010-01-20 18:34 ` Uwe Kleine-König
2010-01-20 18:51 ` [PATCH] otg Kconfig: let USB_OTG_UTILS select " Valentin Longchamp
2010-01-20 19:02 ` Uwe Kleine-König [this message]
2010-01-20 19:06 ` Valentin Longchamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100120190233.GC30066@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).