* [PATCH] ARM: MX3: Fixed typo in declared enum type name.
@ 2010-01-21 9:12 Vladimir Zapolskiy
2010-01-21 9:26 ` Daniel Mack
2010-01-21 13:37 ` Sascha Hauer
0 siblings, 2 replies; 5+ messages in thread
From: Vladimir Zapolskiy @ 2010-01-21 9:12 UTC (permalink / raw)
To: linux-arm-kernel
To distinguish between mx31lite and mx31lilly boards better to use
different enum types.
Signed-off-by: Vladimir Zapolskiy <vzapolskiy@gmail.com>
---
arch/arm/plat-mxc/include/mach/board-mx31lite.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-mxc/include/mach/board-mx31lite.h b/arch/arm/plat-mxc/include/mach/board-mx31lite.h
index 0184b63..2b2da03 100644
--- a/arch/arm/plat-mxc/include/mach/board-mx31lite.h
+++ b/arch/arm/plat-mxc/include/mach/board-mx31lite.h
@@ -25,7 +25,7 @@
#ifndef __ASSEMBLY__
-enum mx31lilly_boards {
+enum mx31lite_boards {
MX31LITE_NOBOARD = 0,
MX31LITE_DB = 1,
};
--
1.6.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] ARM: MX3: Fixed typo in declared enum type name.
2010-01-21 9:12 [PATCH] ARM: MX3: Fixed typo in declared enum type name Vladimir Zapolskiy
@ 2010-01-21 9:26 ` Daniel Mack
2010-01-21 9:35 ` Vladimir Zapolskiy
2010-01-21 13:37 ` Sascha Hauer
1 sibling, 1 reply; 5+ messages in thread
From: Daniel Mack @ 2010-01-21 9:26 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jan 21, 2010 at 12:12:52PM +0300, Vladimir Zapolskiy wrote:
> To distinguish between mx31lite and mx31lilly boards better to use
> different enum types.
True, even though it shouldn't have any impact unless you include both
headers. I assume you didn't meet any real-life problem with that?
> Signed-off-by: Vladimir Zapolskiy <vzapolskiy@gmail.com>
Acked-by: Daniel Mack <daniel@caiaq.de>
> ---
> arch/arm/plat-mxc/include/mach/board-mx31lite.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-mxc/include/mach/board-mx31lite.h b/arch/arm/plat-mxc/include/mach/board-mx31lite.h
> index 0184b63..2b2da03 100644
> --- a/arch/arm/plat-mxc/include/mach/board-mx31lite.h
> +++ b/arch/arm/plat-mxc/include/mach/board-mx31lite.h
> @@ -25,7 +25,7 @@
>
> #ifndef __ASSEMBLY__
>
> -enum mx31lilly_boards {
> +enum mx31lite_boards {
> MX31LITE_NOBOARD = 0,
> MX31LITE_DB = 1,
> };
> --
> 1.6.5.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: MX3: Fixed typo in declared enum type name.
2010-01-21 9:26 ` Daniel Mack
@ 2010-01-21 9:35 ` Vladimir Zapolskiy
2010-01-21 9:52 ` Daniel Mack
0 siblings, 1 reply; 5+ messages in thread
From: Vladimir Zapolskiy @ 2010-01-21 9:35 UTC (permalink / raw)
To: linux-arm-kernel
According to this issue I have not met problems with mx31lite board,
surely that's just a typo. Anyway I plan to continue to work with this
board setup for a while and make some tests of the recent changes
found in 2.6.33.
On Thu, Jan 21, 2010 at 12:26 PM, Daniel Mack <daniel@caiaq.de> wrote:
> On Thu, Jan 21, 2010 at 12:12:52PM +0300, Vladimir Zapolskiy wrote:
>> To distinguish between mx31lite and mx31lilly boards better to use
>> different enum types.
>
> True, even though it shouldn't have any impact unless you include both
> headers. I assume you didn't meet any real-life problem with that?
>
>> Signed-off-by: Vladimir Zapolskiy <vzapolskiy@gmail.com>
>
> Acked-by: Daniel Mack <daniel@caiaq.de>
>
>
>> ---
>> ?arch/arm/plat-mxc/include/mach/board-mx31lite.h | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/plat-mxc/include/mach/board-mx31lite.h b/arch/arm/plat-mxc/include/mach/board-mx31lite.h
>> index 0184b63..2b2da03 100644
>> --- a/arch/arm/plat-mxc/include/mach/board-mx31lite.h
>> +++ b/arch/arm/plat-mxc/include/mach/board-mx31lite.h
>> @@ -25,7 +25,7 @@
>>
>> ?#ifndef __ASSEMBLY__
>>
>> -enum mx31lilly_boards {
>> +enum mx31lite_boards {
>> ? ? ? MX31LITE_NOBOARD ? ? ? ?= 0,
>> ? ? ? MX31LITE_DB ? ? ? ? ? ? = 1,
>> ?};
>> --
>> 1.6.5.4
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: MX3: Fixed typo in declared enum type name.
2010-01-21 9:35 ` Vladimir Zapolskiy
@ 2010-01-21 9:52 ` Daniel Mack
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Mack @ 2010-01-21 9:52 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jan 21, 2010 at 12:35:22PM +0300, Vladimir Zapolskiy wrote:
> According to this issue I have not met problems with mx31lite board,
> surely that's just a typo. Anyway I plan to continue to work with this
> board setup for a while and make some tests of the recent changes
> found in 2.6.33.
Good to hear, more testing is certainly needed.
Thanks,
Daniel
> On Thu, Jan 21, 2010 at 12:26 PM, Daniel Mack <daniel@caiaq.de> wrote:
> > On Thu, Jan 21, 2010 at 12:12:52PM +0300, Vladimir Zapolskiy wrote:
> >> To distinguish between mx31lite and mx31lilly boards better to use
> >> different enum types.
> >
> > True, even though it shouldn't have any impact unless you include both
> > headers. I assume you didn't meet any real-life problem with that?
> >
> >> Signed-off-by: Vladimir Zapolskiy <vzapolskiy@gmail.com>
> >
> > Acked-by: Daniel Mack <daniel@caiaq.de>
> >
> >
> >> ---
> >> ?arch/arm/plat-mxc/include/mach/board-mx31lite.h | ? ?2 +-
> >> ?1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/arch/arm/plat-mxc/include/mach/board-mx31lite.h b/arch/arm/plat-mxc/include/mach/board-mx31lite.h
> >> index 0184b63..2b2da03 100644
> >> --- a/arch/arm/plat-mxc/include/mach/board-mx31lite.h
> >> +++ b/arch/arm/plat-mxc/include/mach/board-mx31lite.h
> >> @@ -25,7 +25,7 @@
> >>
> >> ?#ifndef __ASSEMBLY__
> >>
> >> -enum mx31lilly_boards {
> >> +enum mx31lite_boards {
> >> ? ? ? MX31LITE_NOBOARD ? ? ? ?= 0,
> >> ? ? ? MX31LITE_DB ? ? ? ? ? ? = 1,
> >> ?};
> >> --
> >> 1.6.5.4
> >>
> >
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: MX3: Fixed typo in declared enum type name.
2010-01-21 9:12 [PATCH] ARM: MX3: Fixed typo in declared enum type name Vladimir Zapolskiy
2010-01-21 9:26 ` Daniel Mack
@ 2010-01-21 13:37 ` Sascha Hauer
1 sibling, 0 replies; 5+ messages in thread
From: Sascha Hauer @ 2010-01-21 13:37 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jan 21, 2010 at 12:12:52PM +0300, Vladimir Zapolskiy wrote:
> To distinguish between mx31lite and mx31lilly boards better to use
> different enum types.
>
> Signed-off-by: Vladimir Zapolskiy <vzapolskiy@gmail.com>
Ok, scheduled for -rc.
Sascha
> ---
> arch/arm/plat-mxc/include/mach/board-mx31lite.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-mxc/include/mach/board-mx31lite.h b/arch/arm/plat-mxc/include/mach/board-mx31lite.h
> index 0184b63..2b2da03 100644
> --- a/arch/arm/plat-mxc/include/mach/board-mx31lite.h
> +++ b/arch/arm/plat-mxc/include/mach/board-mx31lite.h
> @@ -25,7 +25,7 @@
>
> #ifndef __ASSEMBLY__
>
> -enum mx31lilly_boards {
> +enum mx31lite_boards {
> MX31LITE_NOBOARD = 0,
> MX31LITE_DB = 1,
> };
> --
> 1.6.5.4
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-01-21 13:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-21 9:12 [PATCH] ARM: MX3: Fixed typo in declared enum type name Vladimir Zapolskiy
2010-01-21 9:26 ` Daniel Mack
2010-01-21 9:35 ` Vladimir Zapolskiy
2010-01-21 9:52 ` Daniel Mack
2010-01-21 13:37 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).