From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] RFC: make struct platform_driver.id_table const
Date: Mon, 25 Jan 2010 01:34:21 +0000 [thread overview]
Message-ID: <20100125013421.GL26562@trinity.fluff.org> (raw)
In-Reply-To: <1264179837-22999-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Fri, Jan 22, 2010 at 06:03:57PM +0100, Uwe Kleine-K?nig wrote:
> This fixes a warning on several pxa based machines:
>
> arch/arm/mach-pxa/ssp.c:475: warning: initialization discards qualifiers from pointer target type
this looks sane to me.
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Cc: Eric Miao <eric.miao@marvell.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> ---
> drivers/base/platform.c | 2 +-
> include/linux/platform_device.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 58efaf2..962246c 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -578,7 +578,7 @@ static int platform_uevent(struct device *dev, struct kobj_uevent_env *env)
> }
>
> static const struct platform_device_id *platform_match_id(
> - struct platform_device_id *id,
> + const struct platform_device_id *id,
> struct platform_device *pdev)
> {
> while (id->name[0]) {
> diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
> index 71ff887..3a6201e 100644
> --- a/include/linux/platform_device.h
> +++ b/include/linux/platform_device.h
> @@ -21,7 +21,7 @@ struct platform_device {
> u32 num_resources;
> struct resource * resource;
>
> - struct platform_device_id *id_entry;
> + const struct platform_device_id *id_entry;
>
> /* arch specific additions */
> struct pdev_archdata archdata;
> @@ -62,7 +62,7 @@ struct platform_driver {
> int (*suspend)(struct platform_device *, pm_message_t state);
> int (*resume)(struct platform_device *);
> struct device_driver driver;
> - struct platform_device_id *id_table;
> + const struct platform_device_id *id_table;
> };
>
> extern int platform_driver_register(struct platform_driver *);
> --
> 1.6.6
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2010-01-25 1:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 17:03 [PATCH] RFC: make struct platform_driver.id_table const Uwe Kleine-König
2010-01-25 1:34 ` Ben Dooks [this message]
2010-01-25 2:15 ` Vikram Dhillon
2010-01-25 7:42 ` Uwe Kleine-König
2010-01-25 21:12 ` Vikram Dhillon
2010-01-26 6:01 ` Eric Miao
2010-01-26 8:35 ` Uwe Kleine-König
2010-01-26 8:54 ` Eric Miao
2010-01-28 1:11 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125013421.GL26562@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).