From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] omap: define _toggle_gpio_edge_triggering only for OMAP1
Date: Mon, 25 Jan 2010 16:28:32 -0800 [thread overview]
Message-ID: <20100126002832.GD2879@atomide.com> (raw)
In-Reply-To: <87sk9u6o4l.fsf@deeprootsystems.com>
* Kevin Hilman <khilman@deeprootsystems.com> [100125 10:20]:
> Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> writes:
>
> > The only usage of _toggle_gpio_edge_triggering is in an
> > CONFIG_ARCH_OMAP1 is defined, too.
> >
> > This fixes a compiler warning:
> >
> > arch/arm/plat-omap/gpio.c:758: warning: '_toggle_gpio_edge_triggering' defined but not used
> >
> > when compiling for ARCH_OMAP2, ARCH_OMAP3 or ARCH_OMAP4.
> >
> > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
>
> Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
Ack, I'll add this into omap-fixes for the -rc cycle.
Regards,
Tony
> > ---
> > arch/arm/plat-omap/gpio.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> > index d17620c..d2422c7 100644
> > --- a/arch/arm/plat-omap/gpio.c
> > +++ b/arch/arm/plat-omap/gpio.c
> > @@ -750,6 +750,7 @@ static inline void set_24xx_gpio_triggering(struct gpio_bank *bank, int gpio,
> > }
> > #endif
> >
> > +#ifdef CONFIG_ARCH_OMAP1
> > /*
> > * This only applies to chips that can't do both rising and falling edge
> > * detection at once. For all other chips, this function is a noop.
> > @@ -760,11 +761,9 @@ static void _toggle_gpio_edge_triggering(struct gpio_bank *bank, int gpio)
> > u32 l = 0;
> >
> > switch (bank->method) {
> > -#ifdef CONFIG_ARCH_OMAP1
> > case METHOD_MPUIO:
> > reg += OMAP_MPUIO_GPIO_INT_EDGE;
> > break;
> > -#endif
> > #ifdef CONFIG_ARCH_OMAP15XX
> > case METHOD_GPIO_1510:
> > reg += OMAP1510_GPIO_INT_CONTROL;
> > @@ -787,6 +786,7 @@ static void _toggle_gpio_edge_triggering(struct gpio_bank *bank, int gpio)
> >
> > __raw_writel(l, reg);
> > }
> > +#endif
> >
> > static int _set_gpio_triggering(struct gpio_bank *bank, int gpio, int trigger)
> > {
> > --
> > 1.6.6
prev parent reply other threads:[~2010-01-26 0:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 21:01 [PATCH 2/2] omap: define _toggle_gpio_edge_triggering only for OMAP1 Uwe Kleine-König
2010-01-25 18:22 ` Kevin Hilman
2010-01-26 0:28 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100126002832.GD2879@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).