linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 01/10] ARM: S3C2443: GPIO: Correct AC97 pin defines
Date: Wed, 27 Jan 2010 08:11:40 +0000	[thread overview]
Message-ID: <20100127081140.GK9153@trinity.fluff.org> (raw)
In-Reply-To: <1264571873-14924-1-git-send-email-jassisinghbrar@gmail.com>

On Wed, Jan 27, 2010 at 02:57:53PM +0900, jassisinghbrar at gmail.com wrote:
> From: Jassi Brar <jassi.brar@samsung.com>
> 
> GPIO_E-[5,9] pin functionality was defined incorrectly.
> The patch corrects and adds missing pins.

Ok, should I apply this to the fixes tree and send to linus?
 
> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
> ---
>  arch/arm/mach-s3c2410/include/mach/regs-gpio.h |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c2410/include/mach/regs-gpio.h b/arch/arm/mach-s3c2410/include/mach/regs-gpio.h
> index ebc85c6..fd672f3 100644
> --- a/arch/arm/mach-s3c2410/include/mach/regs-gpio.h
> +++ b/arch/arm/mach-s3c2410/include/mach/regs-gpio.h
> @@ -406,31 +406,31 @@
>  #define S3C2443_GPE5_SD1_CLK   (0x02 << 10)
>  #define S3C2400_GPE5_EINT5     (0x02 << 10)
>  #define S3C2400_GPE5_TCLK1     (0x03 << 10)
> +#define S3C2443_GPE5_AC_BITCLK (0x03 << 10)
>  
>  #define S3C2410_GPE6_SDCMD     (0x02 << 12)
>  #define S3C2443_GPE6_SD1_CMD   (0x02 << 12)
> -#define S3C2443_GPE6_AC_BITCLK (0x03 << 12)
> +#define S3C2443_GPE6_AC_SDI    (0x03 << 12)
>  #define S3C2400_GPE6_EINT6     (0x02 << 12)
>  
>  #define S3C2410_GPE7_SDDAT0    (0x02 << 14)
>  #define S3C2443_GPE5_SD1_DAT0  (0x02 << 14)
> -#define S3C2443_GPE7_AC_SDI    (0x03 << 14)
> +#define S3C2443_GPE7_AC_SDO    (0x03 << 14)
>  #define S3C2400_GPE7_EINT7     (0x02 << 14)
>  
>  #define S3C2410_GPE8_SDDAT1    (0x02 << 16)
>  #define S3C2443_GPE8_SD1_DAT1  (0x02 << 16)
> -#define S3C2443_GPE8_AC_SDO    (0x03 << 16)
> +#define S3C2443_GPE8_AC_SYNC   (0x03 << 16)
>  #define S3C2400_GPE8_nXDACK0   (0x02 << 16)
>  
>  #define S3C2410_GPE9_SDDAT2    (0x02 << 18)
>  #define S3C2443_GPE9_SD1_DAT2  (0x02 << 18)
> -#define S3C2443_GPE9_AC_SYNC   (0x03 << 18)
> +#define S3C2443_GPE9_AC_nRESET (0x03 << 18)
>  #define S3C2400_GPE9_nXDACK1   (0x02 << 18)
>  #define S3C2400_GPE9_nXBACK    (0x03 << 18)
>  
>  #define S3C2410_GPE10_SDDAT3   (0x02 << 20)
>  #define S3C2443_GPE10_SD1_DAT3 (0x02 << 20)
> -#define S3C2443_GPE10_AC_nRESET (0x03 << 20)
>  #define S3C2400_GPE10_nXDREQ0  (0x02 << 20)
>  
>  #define S3C2410_GPE11_SPIMISO0 (0x02 << 22)
> -- 
> 1.6.2.5
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

  reply	other threads:[~2010-01-27  8:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27  5:57 [PATCHv2 01/10] ARM: S3C2443: GPIO: Correct AC97 pin defines jassisinghbrar at gmail.com
2010-01-27  8:11 ` Ben Dooks [this message]
2010-01-27  8:15   ` jassi brar
2010-01-27  8:24     ` Ben Dooks
2010-01-27  8:28       ` jassi brar
2010-01-27 10:29     ` Mark Brown
2010-01-27 10:37       ` jassi brar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100127081140.GK9153@trinity.fluff.org \
    --to=ben-linux@fluff.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).