linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ben@trinity.fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 06/10] ARM: SMDK64XX: Enable AC97 device
Date: Thu, 28 Jan 2010 03:41:52 +0000	[thread overview]
Message-ID: <20100128034152.GA14154@trinity.fluff.org> (raw)
In-Reply-To: <1264571969-15145-1-git-send-email-jassisinghbrar@gmail.com>

On Wed, Jan 27, 2010 at 02:59:29PM +0900, jassisinghbrar at gmail.com wrote:
> From: Jassi Brar <jassi.brar@samsung.com>
> 
> Add AC97 controller to platform devices and initialize the AC97 gpios.

I'd much rather see platform devices always added unless there is a really
good reason not to. People can build things as modules and this means you
end up having to rebuild the core kernel as well as the module if you want
to change.
 
> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
> ---
>  arch/arm/mach-s3c6410/mach-smdk6410.c |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c6410/mach-smdk6410.c b/arch/arm/mach-s3c6410/mach-smdk6410.c
> index eba345f..259ebbb 100644
> --- a/arch/arm/mach-s3c6410/mach-smdk6410.c
> +++ b/arch/arm/mach-s3c6410/mach-smdk6410.c
> @@ -55,6 +55,7 @@
>  #include <plat/gpio-cfg.h>
>  
>  #include <plat/s3c6410.h>
> +#include <plat/audio.h>
>  #include <plat/clock.h>
>  #include <plat/devs.h>
>  #include <plat/cpu.h>
> @@ -253,7 +254,9 @@ static struct platform_device *smdk6410_devices[] __initdata = {
>  	&smdk6410_b_pwr_5v,
>  #endif
>  	&smdk6410_lcd_powerdev,
> -
> +#ifdef CONFIG_SND_SOC_SMDK_WM9713
> +	&s3c64xx_device_ac97,
> +#endif
>  	&smdk6410_smsc911x,
>  };
>  
> @@ -475,6 +478,10 @@ static void __init smdk6410_machine_init(void)
>  	i2c_register_board_info(0, i2c_devs0, ARRAY_SIZE(i2c_devs0));
>  	i2c_register_board_info(1, i2c_devs1, ARRAY_SIZE(i2c_devs1));
>  
> +#ifdef CONFIG_SND_SOC_SMDK_WM9713
> +	s3c64xx_ac97_setup_gpio(S3C64XX_AC97_GPD);
> +#endif
> +
>  	platform_add_devices(smdk6410_devices, ARRAY_SIZE(smdk6410_devices));
>  }
>  
> -- 
> 1.6.2.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

  parent reply	other threads:[~2010-01-28  3:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27  5:59 [PATCHv2 06/10] ARM: SMDK64XX: Enable AC97 device jassisinghbrar at gmail.com
2010-01-27 10:45 ` Mark Brown
2010-01-28  3:41 ` Ben Dooks [this message]
2010-01-28  4:08   ` jassi brar
2010-01-28  5:31     ` jassi brar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100128034152.GA14154@trinity.fluff.org \
    --to=ben@trinity.fluff.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).