* [PATCHv2] ARM: S3C64XX: SPI: Make platform device compilation selectable
@ 2010-01-28 8:14 jassisinghbrar at gmail.com
2010-01-28 8:23 ` Ben Dooks
2010-01-28 9:02 ` Uwe Kleine-König
0 siblings, 2 replies; 5+ messages in thread
From: jassisinghbrar at gmail.com @ 2010-01-28 8:14 UTC (permalink / raw)
To: linux-arm-kernel
From: Jassi Brar <jassi.brar@samsung.com>
The SPI controller platform devices should be compiled in
independent of the driver support, otherwise we might end
up with dev-spi built as kernel module.
Change this to make every machine select if it has some SPI
device and wants to build device definitions.
Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
---
arch/arm/plat-s3c64xx/Makefile | 4 +++-
arch/arm/plat-samsung/Kconfig | 6 ++++++
2 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-s3c64xx/Makefile b/arch/arm/plat-s3c64xx/Makefile
index 80255a5..e60bde3 100644
--- a/arch/arm/plat-s3c64xx/Makefile
+++ b/arch/arm/plat-s3c64xx/Makefile
@@ -40,6 +40,9 @@ obj-$(CONFIG_S3C64XX_DMA) += dma.o
obj-$(CONFIG_S3C_ADC) += dev-adc.o
+# SPI support
+obj-$(CONFIG_S3C64XX_DEV_SPI) += dev-spi.o
+
# Device setup
obj-$(CONFIG_S3C64XX_SETUP_I2C0) += setup-i2c0.o
@@ -47,4 +50,3 @@ obj-$(CONFIG_S3C64XX_SETUP_I2C1) += setup-i2c1.o
obj-$(CONFIG_S3C64XX_SETUP_FB_24BPP) += setup-fb-24bpp.o
obj-$(CONFIG_S3C64XX_SETUP_SDHCI_GPIO) += setup-sdhci-gpio.o
obj-$(CONFIG_SND_S3C24XX_SOC) += dev-audio.o
-obj-$(CONFIG_SPI_S3C64XX) += dev-spi.o
diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
index 1c2fe91..72da646 100644
--- a/arch/arm/plat-samsung/Kconfig
+++ b/arch/arm/plat-samsung/Kconfig
@@ -132,6 +132,12 @@ config S3C_DEV_NAND
help
Compile in platform device definition for NAND controller
+config S3C64XX_DEV_SPI
+ bool
+ help
+ Compile in platform device definitions for S3C64XX's type
+ SPI controllers.
+
comment "Power management"
config SAMSUNG_PM_DEBUG
--
1.6.2.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCHv2] ARM: S3C64XX: SPI: Make platform device compilation selectable
2010-01-28 8:14 [PATCHv2] ARM: S3C64XX: SPI: Make platform device compilation selectable jassisinghbrar at gmail.com
@ 2010-01-28 8:23 ` Ben Dooks
2010-01-28 9:02 ` Uwe Kleine-König
1 sibling, 0 replies; 5+ messages in thread
From: Ben Dooks @ 2010-01-28 8:23 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jan 28, 2010 at 05:14:49PM +0900, jassisinghbrar at gmail.com wrote:
> From: Jassi Brar <jassi.brar@samsung.com>
>
> The SPI controller platform devices should be compiled in
> independent of the driver support, otherwise we might end
> up with dev-spi built as kernel module.
> Change this to make every machine select if it has some SPI
> device and wants to build device definitions.
Ok, will look at applying either otnight or tomorrow.
> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
> ---
> arch/arm/plat-s3c64xx/Makefile | 4 +++-
> arch/arm/plat-samsung/Kconfig | 6 ++++++
> 2 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-s3c64xx/Makefile b/arch/arm/plat-s3c64xx/Makefile
> index 80255a5..e60bde3 100644
> --- a/arch/arm/plat-s3c64xx/Makefile
> +++ b/arch/arm/plat-s3c64xx/Makefile
> @@ -40,6 +40,9 @@ obj-$(CONFIG_S3C64XX_DMA) += dma.o
>
> obj-$(CONFIG_S3C_ADC) += dev-adc.o
>
> +# SPI support
> +obj-$(CONFIG_S3C64XX_DEV_SPI) += dev-spi.o
> +
> # Device setup
>
> obj-$(CONFIG_S3C64XX_SETUP_I2C0) += setup-i2c0.o
> @@ -47,4 +50,3 @@ obj-$(CONFIG_S3C64XX_SETUP_I2C1) += setup-i2c1.o
> obj-$(CONFIG_S3C64XX_SETUP_FB_24BPP) += setup-fb-24bpp.o
> obj-$(CONFIG_S3C64XX_SETUP_SDHCI_GPIO) += setup-sdhci-gpio.o
> obj-$(CONFIG_SND_S3C24XX_SOC) += dev-audio.o
> -obj-$(CONFIG_SPI_S3C64XX) += dev-spi.o
> diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
> index 1c2fe91..72da646 100644
> --- a/arch/arm/plat-samsung/Kconfig
> +++ b/arch/arm/plat-samsung/Kconfig
> @@ -132,6 +132,12 @@ config S3C_DEV_NAND
> help
> Compile in platform device definition for NAND controller
>
> +config S3C64XX_DEV_SPI
> + bool
> + help
> + Compile in platform device definitions for S3C64XX's type
> + SPI controllers.
> +
> comment "Power management"
>
> config SAMSUNG_PM_DEBUG
> --
> 1.6.2.5
>
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCHv2] ARM: S3C64XX: SPI: Make platform device compilation selectable
2010-01-28 8:14 [PATCHv2] ARM: S3C64XX: SPI: Make platform device compilation selectable jassisinghbrar at gmail.com
2010-01-28 8:23 ` Ben Dooks
@ 2010-01-28 9:02 ` Uwe Kleine-König
2010-01-28 9:12 ` jassi brar
1 sibling, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2010-01-28 9:02 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Thu, Jan 28, 2010 at 05:14:49PM +0900, jassisinghbrar at gmail.com wrote:
> From: Jassi Brar <jassi.brar@samsung.com>
>
> The SPI controller platform devices should be compiled in
> independent of the driver support, otherwise we might end
> up with dev-spi built as kernel module.
> Change this to make every machine select if it has some SPI
> device and wants to build device definitions.
>
> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
> ---
> arch/arm/plat-s3c64xx/Makefile | 4 +++-
> arch/arm/plat-samsung/Kconfig | 6 ++++++
> 2 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-s3c64xx/Makefile b/arch/arm/plat-s3c64xx/Makefile
> index 80255a5..e60bde3 100644
> --- a/arch/arm/plat-s3c64xx/Makefile
> +++ b/arch/arm/plat-s3c64xx/Makefile
> @@ -40,6 +40,9 @@ obj-$(CONFIG_S3C64XX_DMA) += dma.o
>
> obj-$(CONFIG_S3C_ADC) += dev-adc.o
>
> +# SPI support
> +obj-$(CONFIG_S3C64XX_DEV_SPI) += dev-spi.o
> +
> # Device setup
>
> obj-$(CONFIG_S3C64XX_SETUP_I2C0) += setup-i2c0.o
> @@ -47,4 +50,3 @@ obj-$(CONFIG_S3C64XX_SETUP_I2C1) += setup-i2c1.o
> obj-$(CONFIG_S3C64XX_SETUP_FB_24BPP) += setup-fb-24bpp.o
> obj-$(CONFIG_S3C64XX_SETUP_SDHCI_GPIO) += setup-sdhci-gpio.o
> obj-$(CONFIG_SND_S3C24XX_SOC) += dev-audio.o
> -obj-$(CONFIG_SPI_S3C64XX) += dev-spi.o
> diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
> index 1c2fe91..72da646 100644
> --- a/arch/arm/plat-samsung/Kconfig
> +++ b/arch/arm/plat-samsung/Kconfig
> @@ -132,6 +132,12 @@ config S3C_DEV_NAND
> help
> Compile in platform device definition for NAND controller
>
> +config S3C64XX_DEV_SPI
> + bool
> + help
> + Compile in platform device definitions for S3C64XX's type
> + SPI controllers.
> +
> comment "Power management"
>
> config SAMSUNG_PM_DEBUG
Is it correct that S3C64XX_DEV_SPI for now is always unselected and so
dev-spi.o is never compiled? Assuming there are already machines using
it the corresponding symbols should select S3C64XX_DEV_SPI, don't they?
If that's wrong the last sentence in your commit log is confusing.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCHv2] ARM: S3C64XX: SPI: Make platform device compilation selectable
2010-01-28 9:02 ` Uwe Kleine-König
@ 2010-01-28 9:12 ` jassi brar
2010-01-28 9:29 ` Uwe Kleine-König
0 siblings, 1 reply; 5+ messages in thread
From: jassi brar @ 2010-01-28 9:12 UTC (permalink / raw)
To: linux-arm-kernel
2010/1/28 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> On Thu, Jan 28, 2010 at 05:14:49PM +0900, jassisinghbrar at gmail.com wrote:
>> From: Jassi Brar <jassi.brar@samsung.com>
>>
>> The SPI controller platform devices should be compiled in
>> independent of the driver support, otherwise we might end
>> up with dev-spi built as kernel module.
>> Change this to make every machine select if it has some SPI
>> device and wants to build device definitions.
> Is it correct that S3C64XX_DEV_SPI for now is always unselected and so
> dev-spi.o is never compiled? ?Assuming there are already machines using
> it the corresponding symbols should select S3C64XX_DEV_SPI, don't they?
>
> If that's wrong the last sentence in your commit log is confusing.
Hello,
No machine currently uses s3c64xx-spi, so it's ok.
In future a s3c64xx based machine has to select S3C64XX_DEV_SPI
if it has some device attached to the SPI bus.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCHv2] ARM: S3C64XX: SPI: Make platform device compilation selectable
2010-01-28 9:12 ` jassi brar
@ 2010-01-28 9:29 ` Uwe Kleine-König
0 siblings, 0 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2010-01-28 9:29 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jan 28, 2010 at 06:12:30PM +0900, jassi brar wrote:
> 2010/1/28 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> > On Thu, Jan 28, 2010 at 05:14:49PM +0900, jassisinghbrar at gmail.com wrote:
> >> From: Jassi Brar <jassi.brar@samsung.com>
> >>
> >> The SPI controller platform devices should be compiled in
> >> independent of the driver support, otherwise we might end
> >> up with dev-spi built as kernel module.
> >> Change this to make every machine select if it has some SPI
> >> device and wants to build device definitions.
> > Is it correct that S3C64XX_DEV_SPI for now is always unselected and so
> > dev-spi.o is never compiled? ?Assuming there are already machines using
> > it the corresponding symbols should select S3C64XX_DEV_SPI, don't they?
> >
> > If that's wrong the last sentence in your commit log is confusing.
> Hello,
> No machine currently uses s3c64xx-spi, so it's ok.
> In future a s3c64xx based machine has to select S3C64XX_DEV_SPI
> if it has some device attached to the SPI bus.
OK, then maybe change the commit log to:
The SPI controller platform devices should be compiled in
independent of the driver support, otherwise we might end up
with dev-spi built as kernel module.
So now every machine that has some SPI device should select
S3C64XX_DEV_SPI. Currently there is no such machine in mainline
yet.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-01-28 9:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-28 8:14 [PATCHv2] ARM: S3C64XX: SPI: Make platform device compilation selectable jassisinghbrar at gmail.com
2010-01-28 8:23 ` Ben Dooks
2010-01-28 9:02 ` Uwe Kleine-König
2010-01-28 9:12 ` jassi brar
2010-01-28 9:29 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).