From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] input: MXC: add mxc-keypad driver to support the Keypad Port present in the mxc application processors family.
Date: Fri, 29 Jan 2010 22:37:27 +0100 [thread overview]
Message-ID: <20100129213727.GB21364@pengutronix.de> (raw)
In-Reply-To: <1264799926.2975.3.camel@realization>
Hello Alberto,
On Fri, Jan 29, 2010 at 10:18:46PM +0100, Alberto Panizzo wrote:
> The MXC family of Application Processors is shipped with a Keypad Port
would you mind to do s/MXC/IMX/ in your patch? Currently both are used
but we (=Sascha and me) will try to deprecate MXC.
> + * >>Power management need to be implemented<<.
s/need/needs/ (or alternatively do it :-) and maybe s/<<\./.<</ ?
> [...]
> +
> + /* The matrix is stable only if no changes are detected after
> + * MXC_KEYPAD_SCANS_FOR_STABILITY scans */
unusual format of the comment.
/*
* ...
* ...
*/
is the most found way in the kernel for multi-line comments.
> [...]
> +MODULE_LICENSE("GPL v2");
There is no space expected in the string passed to MODULE_LICENSE.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-01-29 21:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 21:18 [PATCH v5] input: MXC: add mxc-keypad driver to support the Keypad Port present in the mxc application processors family Alberto Panizzo
2010-01-29 21:37 ` Uwe Kleine-König [this message]
2010-01-29 22:02 ` Alberto Panizzo
2010-01-30 11:27 ` Alberto Panizzo
2010-01-30 11:56 ` Uwe Kleine-König
2010-01-29 21:50 ` Dmitry Torokhov
2010-01-29 22:18 ` Alberto Panizzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129213727.GB21364@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).