From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ftrace: re-enable dynamic ftrace for ARM
Date: Mon, 1 Feb 2010 22:23:19 +0530 [thread overview]
Message-ID: <20100201165318.GA1846@debian> (raw)
In-Reply-To: <20100201102843.GA31714@pengutronix.de>
On Mon, Feb 01, 2010 at 11:28:43AM +0100, Uwe Kleine-K?nig wrote:
> On Sun, Jan 31, 2010 at 11:03:16PM +0530, Rabin Vincent wrote:
> > This adds mcount recording and updates dynamic ftrace for ARM to work
> > with the new ftrace dyamic tracing implementation.
[...]
> Wouldn't it be nice to patch out the instruction pushing lr to the
> stack (in the gnu case)? Should work, shouldn't it.
It would and it should, but the main reasons I didn't do that were:
- Thumb-2 support needs the LR to be in place, since even -mapcs-frame
does not seem to give us an APCS frame there. The LR would also
be needed if GCC gains the ability to build without frame pointers
with -pg.
- I'm not sure we would gain much performance by patching it out, and
I'd really like to avoid patching more than what is really necessary
and to keep the code as similar as possible to the other arches.
Rabin
next prev parent reply other threads:[~2010-02-01 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 17:33 [PATCH 1/2] ftrace: pass KBUILD_CFLAGS along with CC to record_mcount.pl Rabin Vincent
2010-01-31 17:33 ` [PATCH 2/2] ftrace: re-enable dynamic ftrace for ARM Rabin Vincent
2010-02-01 10:28 ` Uwe Kleine-König
2010-02-01 16:53 ` Rabin Vincent [this message]
2010-02-01 21:11 ` Uwe Kleine-König
2010-02-13 19:54 ` Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100201165318.GA1846@debian \
--to=rabin@rab.in \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).