From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.hauer@pengutronix.de (Sascha Hauer) Date: Wed, 3 Feb 2010 10:40:16 +0100 Subject: [PATCHv2 03/11] mxc: Fix Drive Strength Field in the IOMUX controller In-Reply-To: References: <0511204199ab83aed2340e70a4639500c0528dab.1265173480.git.amit.kucheria@canonical.com> <9fa7a3c70c46a1f776c6520051481cff6525ef02.1265173480.git.amit.kucheria@canonical.com> Message-ID: <20100203094016.GL6130@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Feb 02, 2010 at 10:29:50PM -0800, Eric Miao wrote: > On Tue, Feb 2, 2010 at 9:16 PM, Amit Kucheria > wrote: > > i.MX51 defines 4 values: > > > > 00: Low Drive Strength > > 01: Medium Drive Strength > > 10: High Drive Strength > > 11: Max Drive Strength > > > > Signed-off-by: Amit Kucheria > > --- > > ?arch/arm/plat-mxc/include/mach/iomux-v3.h | ? ?8 +++++--- > > ?1 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/plat-mxc/include/mach/iomux-v3.h b/arch/arm/plat-mxc/include/mach/iomux-v3.h > > index 1deda01..f2f73d3 100644 > > --- a/arch/arm/plat-mxc/include/mach/iomux-v3.h > > +++ b/arch/arm/plat-mxc/include/mach/iomux-v3.h > > @@ -81,11 +81,13 @@ struct pad_desc { > > > > ?#define PAD_CTL_ODE ? ? ? ? ? ? ? ? ? ?(1 << 3) > > > > -#define PAD_CTL_DSE_STANDARD ? ? ? ? ? (0 << 1) > > -#define PAD_CTL_DSE_HIGH ? ? ? ? ? ? ? (1 << 1) > > -#define PAD_CTL_DSE_MAX ? ? ? ? ? ? ? ? ? ? ? ?(2 << 1) > > +#define PAD_CTL_DSE_LOW ? ? ? ? ? ? ? ? ? ? ? ?(0 << 1) > > +#define PAD_CTL_DSE_MED ? ? ? ? ? ? ? ? ? ? ? ?(1 << 1) > > +#define PAD_CTL_DSE_HIGH ? ? ? ? ? ? ? (2 << 1) > > +#define PAD_CTL_DSE_MAX ? ? ? ? ? ? ? ? ? ? ? ?(3 << 1) > > > > I'm seeing some changes in recent kernel with introduction of PAD_CTL_DRV_*, > which also affects mx3, think it's a tough problem to keep backward > compatibility > now, one way out is to introduce maybe PAD_CTL_DRV_EXTREME specifically > for imx51. Given that the values are the same on i.MX3 and i.MX51 we could also do a #define PAD_CTL_DSE(x) ((x) << 1) and add a comment for allowed values 0..2 for i.MX3 and 0..3 for i.MX51. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |