[PATCHv2 03/11] mxc: Fix Drive Strength Field in the IOMUX controller

[amit.kucheria@canonical.com (Amit Kucheria)]

On 10 Feb 03, Grant Likely wrote:
> On Tue, Feb 2, 2010 at 10:16 PM, Amit Kucheria
> <amit.kucheria@canonical.com> wrote:
> > i.MX51 defines 4 values:
> >
> > 00: Low Drive Strength
> > 01: Medium Drive Strength
> > 10: High Drive Strength
> > 11: Max Drive Strength
> >
> > Signed-off-by: Amit Kucheria <amit.kucheria@canonical.com>
> > ---
> > ?arch/arm/plat-mxc/include/mach/iomux-v3.h | ? ?8 +++++---
> > ?1 files changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/plat-mxc/include/mach/iomux-v3.h b/arch/arm/plat-mxc/include/mach/iomux-v3.h
> > index 1deda01..f2f73d3 100644
> > --- a/arch/arm/plat-mxc/include/mach/iomux-v3.h
> > +++ b/arch/arm/plat-mxc/include/mach/iomux-v3.h
> > @@ -81,11 +81,13 @@ struct pad_desc {
> >
> > ?#define PAD_CTL_ODE ? ? ? ? ? ? ? ? ? ?(1 << 3)
> >
> > -#define PAD_CTL_DSE_STANDARD ? ? ? ? ? (0 << 1)
> > -#define PAD_CTL_DSE_HIGH ? ? ? ? ? ? ? (1 << 1)
> > -#define PAD_CTL_DSE_MAX ? ? ? ? ? ? ? ? ? ? ? ?(2 << 1)
> > +#define PAD_CTL_DSE_LOW ? ? ? ? ? ? ? ? ? ? ? ?(0 << 1)
> > +#define PAD_CTL_DSE_MED ? ? ? ? ? ? ? ? ? ? ? ?(1 << 1)
> > +#define PAD_CTL_DSE_HIGH ? ? ? ? ? ? ? (2 << 1)
> > +#define PAD_CTL_DSE_MAX ? ? ? ? ? ? ? ? ? ? ? ?(3 << 1)
> >
> > ?#define PAD_CTL_SRE_FAST ? ? ? ? ? ? ? (1 << 0)
> > +#define PAD_CTL_SRE_SLOW ? ? ? ? ? ? ? (0 << 0)
> 
> Shouldn't the addition/change of #defines be done in patches that
> actually use them?

I'll merge it into patch 5 that adds the core support for i.MX5. I kept it
separate because the #defines are a (standalone) property of the IOMUX
controller regardless of whether they are used by i.MX5 or not.

Thanks for all the reviews.

/Amit

-- 
-------------------------------------------------------------------------
Amit Kucheria,				 Kernel Developer, Verdurent
-------------------------------------------------------------------------