linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: amit.kucheria@canonical.com (Amit Kucheria)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/25] imx/mx1: rename files defining a machine to mach-$mach.c
Date: Wed, 3 Feb 2010 17:29:16 -0800	[thread overview]
Message-ID: <20100204012916.GC5274@k2> (raw)
In-Reply-To: <1262967452-24353-8-git-send-email-u.kleine-koenig@pengutronix.de>

On 10 Jan 08, Uwe Kleine-K?nig wrote:
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
> Cc: Darius Augulis <augulis.darius@gmail.com>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
>  arch/arm/mach-mx1/Makefile                      |    4 ++--
>  arch/arm/mach-mx1/{mx1ads.c => mach-mx1ads.c}   |    2 +-
>  arch/arm/mach-mx1/{scb9328.c => mach-scb9328.c} |    2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
>  rename arch/arm/mach-mx1/{mx1ads.c => mach-mx1ads.c} (98%)
>  rename arch/arm/mach-mx1/{scb9328.c => mach-scb9328.c} (98%)

Rethinking about this (based on a similar request for my i.MX5 submission), I
think renaming the boards to mach-* is a bad idea.

Other SoCs (davinci, omap, msm, nomadik, etc.) use the board-* convention. We
already use mach-* for the SoC directory names under arch/arm/. Naming the
boards with mach-* will just cause more confusion.

Regards,
Amit


> diff --git a/arch/arm/mach-mx1/Makefile b/arch/arm/mach-mx1/Makefile
> index b72f536..297d172 100644
> --- a/arch/arm/mach-mx1/Makefile
> +++ b/arch/arm/mach-mx1/Makefile
> @@ -10,5 +10,5 @@ obj-y			+= generic.o clock.o devices.o
>  obj-$(CONFIG_MX1_VIDEO)	+= ksym_mx1.o mx1_camera_fiq.o
>  
>  # Specific board support
> -obj-$(CONFIG_ARCH_MX1ADS) += mx1ads.o
> -obj-$(CONFIG_MACH_SCB9328) += scb9328.o
> +obj-$(CONFIG_ARCH_MX1ADS) += mach-mx1ads.o
> +obj-$(CONFIG_MACH_SCB9328) += mach-scb9328.o
> diff --git a/arch/arm/mach-mx1/mx1ads.c b/arch/arm/mach-mx1/mach-mx1ads.c
> similarity index 98%
> rename from arch/arm/mach-mx1/mx1ads.c
> rename to arch/arm/mach-mx1/mach-mx1ads.c
> index 30f04e5..a39433a 100644
> --- a/arch/arm/mach-mx1/mx1ads.c
> +++ b/arch/arm/mach-mx1/mach-mx1ads.c
> @@ -1,5 +1,5 @@
>  /*
> - * arch/arm/mach-imx/mx1ads.c
> + * arch/arm/mach-imx/mach-mx1ads.c
>   *
>   * Initially based on:
>   *	linux-2.6.7-imx/arch/arm/mach-imx/scb9328.c
> diff --git a/arch/arm/mach-mx1/scb9328.c b/arch/arm/mach-mx1/mach-scb9328.c
> similarity index 98%
> rename from arch/arm/mach-mx1/scb9328.c
> rename to arch/arm/mach-mx1/mach-scb9328.c
> index 325d98d..b9530d7 100644
> --- a/arch/arm/mach-mx1/scb9328.c
> +++ b/arch/arm/mach-mx1/mach-scb9328.c
> @@ -1,5 +1,5 @@
>  /*
> - * linux/arch/arm/mach-mx1/scb9328.c
> + * linux/arch/arm/mach-mx1/mach-scb9328.c
>   *
>   * Copyright (c) 2004 Sascha Hauer <saschahauer@web.de>
>   * Copyright (c) 2006-2008 Juergen Beisert <jbeisert@netscape.net>
> -- 
> 1.6.5.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
-------------------------------------------------------------------------
Amit Kucheria,				 Kernel Developer, Verdurent
-------------------------------------------------------------------------

  parent reply	other threads:[~2010-02-04  1:29 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-16 18:52 [PATCH 00/20] imx cleanup series Uwe Kleine-König
2009-12-16 18:59 ` [PATCH 01/20] ARM: MX3: make CPU revision number detection work on all boards Uwe Kleine-König
2009-12-16 18:59   ` [PATCH 02/20] imx/mx2: fold crm_regs.h into its only consumer Uwe Kleine-König
2009-12-16 18:59     ` [PATCH 03/20] imx/clock-imx21: use a macro to define registers Uwe Kleine-König
2009-12-16 18:59       ` [PATCH 04/20] imx/clock-imx27: " Uwe Kleine-König
2009-12-16 18:59         ` [PATCH 05/20] imx/mach-mx2: use constants namespaced by the corresponding SOC (easy part) Uwe Kleine-König
2009-12-16 18:59           ` [PATCH 06/20] imx/mach-mx3: " Uwe Kleine-König
2009-12-16 18:59             ` [PATCH 07/20] imx/mx3: rename clock.c and iomux.c to {clock, iomux}-imx31.c Uwe Kleine-König
2009-12-16 18:59               ` [PATCH 08/20] imx/mx1: add newline at end of Makefile Uwe Kleine-König
2009-12-16 18:59                 ` [PATCH 09/20] imx/mx1: rename files defining a machine to mach-$mach.c Uwe Kleine-König
2009-12-16 18:59                   ` [PATCH 10/20] imx: rename Kconfig symbol for "Eukrea CPUIMX27 module" Uwe Kleine-König
2009-12-16 18:59                     ` [PATCH 11/20] imx: rename Kconfig symbol for "LogicPD MX27 LITEKIT platform" Uwe Kleine-König
2009-12-16 18:59                       ` [PATCH 12/20] imx/mx2: rename files defining a machine to mach-$mach.c Uwe Kleine-König
2009-12-16 18:59                         ` [PATCH 13/20] imx/mx3: " Uwe Kleine-König
2009-12-16 18:59                           ` [PATCH 14/20] imx: provide helper macro to define IO_ADDRESS Uwe Kleine-König
2009-12-16 18:59                             ` [PATCH 15/20] imx21: define and use MX21_IO_ADDRESS Uwe Kleine-König
2009-12-16 18:59                               ` [PATCH 16/20] imx27: define and use MX27_IO_ADDRESS Uwe Kleine-König
2009-12-16 18:59                                 ` [PATCH 17/20] imx31: define and use MX31_IO_ADDRESS Uwe Kleine-König
2009-12-16 18:59                                   ` [PATCH 18/20] imx25: redefine MX25_IO_ADDRESS using IMX_IO_ADDRESS Uwe Kleine-König
2009-12-16 19:00                                     ` [PATCH 19/20] imx35: define and use MX35_IO_ADDRESS Uwe Kleine-König
2009-12-16 19:00                                       ` [PATCH 20/20] mx3/kzm_arm11_01: define and use board specific IO_ADDRESS macro Uwe Kleine-König
2009-12-17  7:06                                 ` [PATCH 16/20] imx27: define and use MX27_IO_ADDRESS Lothar Waßmann
2009-12-17  8:28                                   ` Sascha Hauer
2009-12-17 10:05                                   ` Uwe Kleine-König
2009-12-17 11:49                                     ` Lothar Waßmann
2009-12-17 13:17                                       ` Uwe Kleine-König
2009-12-16 20:58                   ` [PATCH 09/20] imx/mx1: rename files defining a machine to mach-$mach.c Guennadi Liakhovetski
2009-12-17  9:32                     ` Uwe Kleine-König
2009-12-16 20:48             ` [PATCH 06/20] imx/mach-mx3: use constants namespaced by the corresponding SOC (easy part) Guennadi Liakhovetski
2009-12-17  7:16         ` [PATCH 04/20] imx/clock-imx27: use a macro to define registers Lothar Waßmann
2009-12-17  9:58           ` Uwe Kleine-König
2010-01-08 16:15 ` [PATCH 00/20] imx cleanup series Uwe Kleine-König
2010-01-08 16:17   ` [PATCH 01/25] imx/mx2: fold crm_regs.h into its only consumer Uwe Kleine-König
2010-01-08 16:17     ` [PATCH 02/25] imx/clock-imx21: use a macro to define registers Uwe Kleine-König
2010-01-08 16:17       ` [PATCH 03/25] imx/clock-imx27: " Uwe Kleine-König
2010-01-08 16:17         ` [PATCH 04/25] imx/mach-mx2: use constants namespaced by the corresponding SOC (easy part) Uwe Kleine-König
2010-01-08 16:17           ` [PATCH 05/25] imx/mach-mx3: " Uwe Kleine-König
2010-01-08 16:17             ` [PATCH 06/25] imx/mx3: rename clock.c and iomux.c to {clock, iomux}-imx31.c Uwe Kleine-König
2010-01-08 16:17               ` [PATCH 07/25] imx/mx1: add newline at end of Makefile Uwe Kleine-König
2010-01-08 16:17                 ` [PATCH 08/25] imx/mx1: rename files defining a machine to mach-$mach.c Uwe Kleine-König
2010-01-08 16:17                   ` [PATCH 09/25] imx: rename Kconfig symbol for "Eukrea CPUIMX27 module" Uwe Kleine-König
2010-01-08 16:17                     ` [PATCH 10/25] imx: rename Kconfig symbol for "LogicPD MX27 LITEKIT platform" Uwe Kleine-König
2010-01-08 16:17                       ` [PATCH 11/25] imx/mx2: rename files defining a machine to mach-$mach.c Uwe Kleine-König
2010-01-08 16:17                         ` [PATCH 12/25] imx/mx3: " Uwe Kleine-König
2010-01-08 16:17                           ` [PATCH 13/25] imx: provide helper macro to define IO_ADDRESS Uwe Kleine-König
2010-01-08 16:17                             ` [PATCH 14/25] imx21: define and use MX21_IO_ADDRESS Uwe Kleine-König
2010-01-08 16:17                               ` [PATCH 15/25] imx27: define and use MX27_IO_ADDRESS Uwe Kleine-König
2010-01-08 16:17                                 ` [PATCH 16/25] imx31: define and use MX31_IO_ADDRESS Uwe Kleine-König
2010-01-08 16:17                                   ` [PATCH 17/25] imx25: redefine MX25_IO_ADDRESS using IMX_IO_ADDRESS Uwe Kleine-König
2010-01-08 16:17                                     ` [PATCH 18/25] imx35: define and use MX35_IO_ADDRESS Uwe Kleine-König
2010-01-08 16:17                                       ` [PATCH 19/25] mx3/kzm_arm11_01: define and use board specific IO_ADDRESS macro Uwe Kleine-König
2010-01-08 16:17                                         ` [PATCH 20/25] imx: mangle addresses after adding the offset Uwe Kleine-König
2010-01-08 16:17                                           ` [PATCH 21/25] imx: only define deprecated symbols conditionally Uwe Kleine-König
2010-01-08 16:17                                             ` [PATCH 22/25] imx: remove mx1ads defconfig Uwe Kleine-König
2010-01-08 16:17                                               ` [PATCH 23/25] imx: remove unneeded include of mach/hardware.h Uwe Kleine-König
2010-01-08 16:17                                                 ` [PATCH 24/25] imx: properly protect mach/mx{1, [25][157x]}.h from multiple inclusion Uwe Kleine-König
2010-01-08 16:17                                                   ` [PATCH 25/25] imx: define functions to configure chip selects in the WEIM Uwe Kleine-König
2010-02-02 13:43                                             ` [PATCH 21/25] imx: only define deprecated symbols conditionally Jiri Kosina
2010-02-02 13:44                                             ` Jiri Kosina
2010-02-02 14:33                                               ` Uwe Kleine-König
2010-02-04  1:29                   ` Amit Kucheria [this message]
2010-02-04  8:45                     ` [PATCH 08/25] imx/mx1: rename files defining a machine to mach-$mach.c Uwe Kleine-König
2010-02-05 17:38                       ` Amit Kucheria
2010-02-04 12:06                     ` Mark Brown
2010-02-04 12:25                       ` Eric Miao
2010-01-14 10:24   ` [PATCH 00/20] imx cleanup series Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100204012916.GC5274@k2 \
    --to=amit.kucheria@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).