public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: amit.walambe@eurotech.com (Amit Walambe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Eurotech Zeus : Making USB port 2 work
Date: Thu, 11 Feb 2010 12:33:44 +0530	[thread overview]
Message-ID: <20100211123344.28014152@ironhide> (raw)
In-Reply-To: <37cba69b59077aff2450e9b89c9d0d20.squirrel@www.loen.fr>

Hi!
Thanks for your comments Marc.

On Wed, 10 Feb 2010 09:38:38 -0000 (GMT)
"Marc Zyngier" <maz@misterjones.org> wrote:
> >  static struct pxaohci_platform_data zeus_ohci_platform_data = {
> >  	.port_mode	= PMM_NPS_MODE,
> > -	.flags		= ENABLE_PORT_ALL |
> > POWER_CONTROL_LOW | POWER_SENSE_LOW,
> > +	/* Clear Power Control Polarity Low and set Power Sense
> > +	 * Polarity Low. Supply power to USB ports. */
> > +	.flags		= ENABLE_PORT_ALL |
> > ~(POWER_CONTROL_LOW) | POWER_SENSE_LOW,
> 
> I suppose that is actually what makes it work, though the change is
> rather suspect. You're basically setting *all* bits to 1
My bad. Attaching a modified patch. I have tested it on a Zeus and it
works ok.

> > -MACHINE_START(ARCOM_ZEUS, "Arcom ZEUS")
> > +MACHINE_START(ARCOM_ZEUS, "Arcom/Eurotech ZEUS")
> 
> Please sent this as a separate patch, including a Signed-off-by: line.
Please see attached.

> Thanks,
> 
>         M.

Thanks and regards,
- Amit

______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email 
______________________________________________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: arcom-to-eurotech.patch
Type: text/x-patch
Size: 667 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100211/e0396c8d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eurotech_zeus_usb_port2.patch
Type: text/x-patch
Size: 829 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100211/e0396c8d/attachment-0001.bin>

  reply	other threads:[~2010-02-11  7:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-10  6:35 [PATCH] Eurotech Zeus : Making USB port 2 work Amit Walambe
2010-02-10  9:38 ` Marc Zyngier
2010-02-11  7:03   ` Amit Walambe [this message]
2010-02-11  9:32     ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100211123344.28014152@ironhide \
    --to=amit.walambe@eurotech.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox